Removed unesscery ids, res, etc

app/src/main/java/code/name/monkey/retromusic/adapter/SearchAdapter.kt

@@ -26,6 +26,7 @@ import androidx.recyclerview.widget.RecyclerView
 import code.name.monkey.appthemehelper.ThemeStore
 import code.name.monkey.retromusic.*
 import code.name.monkey.retromusic.adapter.base.MediaEntryViewHolder
+import code.name.monkey.retromusic.db.PlaylistEntity
 import code.name.monkey.retromusic.db.PlaylistWithSongs
 import code.name.monkey.retromusic.glide.AlbumGlideRequest
 import code.name.monkey.retromusic.glide.ArtistGlideRequest
@@ -52,7 +53,7 @@ class SearchAdapter(
         if (dataSet[position] is Album) return ALBUM
         if (dataSet[position] is Artist) return ARTIST
         if (dataSet[position] is Genre) return GENRE
-        if (dataSet[position] is PlaylistWithSongs) return PLAYLIST
+        if (dataSet[position] is PlaylistEntity) return PLAYLIST
         return if (dataSet[position] is Song) SONG else HEADER
     }
 
@@ -107,9 +108,9 @@ class SearchAdapter(
                 )
             }
             PLAYLIST -> {
-                val playlist = dataSet[position] as PlaylistWithSongs
-                holder.title?.text = playlist.playlistEntity.playlistName
-                holder.text?.text = MusicUtil.playlistInfoString(activity, playlist.songs)
+                val playlist = dataSet[position] as PlaylistEntity
+                holder.title?.text = playlist.playlistName
+                //holder.text?.text = MusicUtil.playlistInfoString(activity, playlist.songs)
             }
             else -> {
                 holder.title?.text = dataSet[position].toString()

app/src/main/java/code/name/monkey/retromusic/adapter/album/AlbumAdapter.kt

@@ -89,15 +89,6 @@ open class AlbumAdapter(
         holder.itemView.isActivated = isChecked
         holder.title?.text = getAlbumTitle(album)
         holder.text?.text = getAlbumText(album)
-        holder.playSongs?.setOnClickListener {
-            album.songs.let { songs ->
-                MusicPlayerRemote.openQueue(
-                    songs,
-                    0,
-                    true
-                )
-            }
-        }
         loadAlbumCover(album, holder)
     }
 

app/src/main/java/code/name/monkey/retromusic/adapter/base/MediaEntryViewHolder.java

@@ -51,7 +51,6 @@ public class MediaEntryViewHolder extends AbstractDraggableSwipeableItemViewHold
 
   @Nullable public View paletteColorContainer;
 
-  @Nullable public ImageButton playSongs;
 
   @Nullable public RecyclerView recyclerView;
 
@@ -83,7 +82,6 @@ public class MediaEntryViewHolder extends AbstractDraggableSwipeableItemViewHold
     paletteColorContainer = itemView.findViewById(R.id.paletteColorContainer);
     recyclerView = itemView.findViewById(R.id.recycler_view);
     mask = itemView.findViewById(R.id.mask);
-    playSongs = itemView.findViewById(R.id.playSongs);
     dummyContainer = itemView.findViewById(R.id.dummy_view);
 
     if (imageContainerCard != null) {

app/src/main/java/code/name/monkey/retromusic/extensions/ViewExtensions.kt

@@ -75,3 +75,4 @@ fun BottomSheetBehavior<*>.peekHeightAnimate(value: Int) {
             start()
         }
 }
+

app/src/main/java/code/name/monkey/retromusic/fragments/LibraryViewModel.kt

@@ -15,36 +15,19 @@
 package code.name.monkey.retromusic.fragments
 
 import android.widget.Toast
-import androidx.lifecycle.LiveData
-import androidx.lifecycle.MutableLiveData
-import androidx.lifecycle.ViewModel
-import androidx.lifecycle.liveData
-import androidx.lifecycle.viewModelScope
-import code.name.monkey.retromusic.App
-import code.name.monkey.retromusic.RECENT_ALBUMS
-import code.name.monkey.retromusic.RECENT_ARTISTS
-import code.name.monkey.retromusic.TOP_ALBUMS
-import code.name.monkey.retromusic.TOP_ARTISTS
-import code.name.monkey.retromusic.db.PlaylistEntity
-import code.name.monkey.retromusic.db.PlaylistWithSongs
-import code.name.monkey.retromusic.db.SongEntity
-import code.name.monkey.retromusic.db.toSong
-import code.name.monkey.retromusic.db.toSongEntity
+import androidx.lifecycle.*
+import code.name.monkey.retromusic.*
+import code.name.monkey.retromusic.db.*
 import code.name.monkey.retromusic.fragments.ReloadType.*
 import code.name.monkey.retromusic.helper.MusicPlayerRemote
 import code.name.monkey.retromusic.interfaces.IMusicServiceEventListener
-import code.name.monkey.retromusic.model.Album
-import code.name.monkey.retromusic.model.Artist
-import code.name.monkey.retromusic.model.Contributor
-import code.name.monkey.retromusic.model.Genre
-import code.name.monkey.retromusic.model.Home
-import code.name.monkey.retromusic.model.Playlist
-import code.name.monkey.retromusic.model.Song
+import code.name.monkey.retromusic.model.*
 import code.name.monkey.retromusic.repository.RealRepository
-import code.name.monkey.retromusic.state.NowPlayingPanelState
 import code.name.monkey.retromusic.util.PreferenceUtil
 import kotlinx.coroutines.Dispatchers.IO
+import kotlinx.coroutines.Dispatchers.Main
 import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
 
 class LibraryViewModel(
     private val repository: RealRepository
@@ -152,9 +135,11 @@ class LibraryViewModel(
         }
     }
 
-    fun search(query: String?) = viewModelScope.launch(IO) {
-        val result = repository.search(query)
-        searchResults.postValue(result)
+    fun search(query: String?) {
+        viewModelScope.launch(IO) {
+            val result = repository.search(query)
+            withContext(Main) { searchResults.postValue(result) }
+        }
     }
 
     fun forceReload(reloadType: ReloadType) = viewModelScope.launch {
@@ -322,7 +307,8 @@ class LibraryViewModel(
         viewModelScope.launch(IO) {
             val playlists = checkPlaylistExists(playlistName)
             if (playlists.isEmpty()) {
-                val playlistId: Long = createPlaylist(PlaylistEntity(playlistName = playlistName))
+                val playlistId: Long =
+                    createPlaylist(PlaylistEntity(playlistName = playlistName))
                 insertSongs(songs.map { it.toSongEntity(playlistId) })
                 forceReload(Playlists)
             } else {

app/src/main/java/code/name/monkey/retromusic/repository/SearchRepository.kt

@@ -26,7 +26,7 @@ class RealSearchRepository(
     private val roomRepository: RoomRepository,
     private val genreRepository: GenreRepository,
 ) {
-    suspend fun searchAll(context: Context, query: String?): MutableList<Any> {
+    fun searchAll(context: Context, query: String?): MutableList<Any> {
         val results = mutableListOf<Any>()
         query?.let { searchString ->
             val songs = songRepository.songs(searchString)
@@ -53,14 +53,14 @@ class RealSearchRepository(
                 results.add(context.resources.getString(R.string.genres))
                 results.addAll(genres)
             }
-            val playlist = roomRepository.playlistWithSongs().filter { playlist ->
-                playlist.playlistEntity.playlistName.toLowerCase(Locale.getDefault())
-                    .contains(searchString.toLowerCase(Locale.getDefault()))
-            }
-            if (playlist.isNotEmpty()) {
-                results.add(context.getString(R.string.playlists))
-                results.addAll(playlist)
-            }
+            /* val playlist = roomRepository.playlists().filter { playlist ->
+                 playlist.playlistName.toLowerCase(Locale.getDefault())
+                     .contains(searchString.toLowerCase(Locale.getDefault()))
+             }
+             if (playlist.isNotEmpty()) {
+                 results.add(context.getString(R.string.playlists))
+                 results.addAll(playlist)
+             }*/
         }
         return results
     }

app/src/main/java/code/name/monkey/retromusic/util/PreferenceUtil.kt

@@ -1,6 +1,5 @@
 package code.name.monkey.retromusic.util
 
-import android.content.Context
 import android.content.SharedPreferences.OnSharedPreferenceChangeListener
 import android.net.ConnectivityManager
 import android.net.NetworkInfo
@@ -8,75 +7,7 @@ import androidx.core.content.ContextCompat
 import androidx.core.content.edit
 import androidx.preference.PreferenceManager
 import androidx.viewpager.widget.ViewPager
-import code.name.monkey.retromusic.ADAPTIVE_COLOR_APP
-import code.name.monkey.retromusic.ALBUM_ARTISTS_ONLY
-import code.name.monkey.retromusic.ALBUM_ART_ON_LOCK_SCREEN
-import code.name.monkey.retromusic.ALBUM_COVER_STYLE
-import code.name.monkey.retromusic.ALBUM_COVER_TRANSFORM
-import code.name.monkey.retromusic.ALBUM_DETAIL_SONG_SORT_ORDER
-import code.name.monkey.retromusic.ALBUM_GRID_SIZE
-import code.name.monkey.retromusic.ALBUM_GRID_SIZE_LAND
-import code.name.monkey.retromusic.ALBUM_GRID_STYLE
-import code.name.monkey.retromusic.ALBUM_SONG_SORT_ORDER
-import code.name.monkey.retromusic.ALBUM_SORT_ORDER
-import code.name.monkey.retromusic.ARTIST_ALBUM_SORT_ORDER
-import code.name.monkey.retromusic.ARTIST_GRID_SIZE
-import code.name.monkey.retromusic.ARTIST_GRID_SIZE_LAND
-import code.name.monkey.retromusic.ARTIST_GRID_STYLE
-import code.name.monkey.retromusic.ARTIST_SONG_SORT_ORDER
-import code.name.monkey.retromusic.ARTIST_SORT_ORDER
-import code.name.monkey.retromusic.AUDIO_DUCKING
-import code.name.monkey.retromusic.AUTO_DOWNLOAD_IMAGES_POLICY
-import code.name.monkey.retromusic.App
-import code.name.monkey.retromusic.BLACK_THEME
-import code.name.monkey.retromusic.BLUETOOTH_PLAYBACK
-import code.name.monkey.retromusic.BLURRED_ALBUM_ART
-import code.name.monkey.retromusic.CAROUSEL_EFFECT
-import code.name.monkey.retromusic.CHOOSE_EQUALIZER
-import code.name.monkey.retromusic.CLASSIC_NOTIFICATION
-import code.name.monkey.retromusic.COLORED_APP_SHORTCUTS
-import code.name.monkey.retromusic.COLORED_NOTIFICATION
-import code.name.monkey.retromusic.DESATURATED_COLOR
-import code.name.monkey.retromusic.EXPAND_NOW_PLAYING_PANEL
-import code.name.monkey.retromusic.EXTRA_SONG_INFO
-import code.name.monkey.retromusic.FILTER_SONG
-import code.name.monkey.retromusic.GAP_LESS_PLAYBACK
-import code.name.monkey.retromusic.GENERAL_THEME
-import code.name.monkey.retromusic.GENRE_SORT_ORDER
-import code.name.monkey.retromusic.HOME_ALBUM_GRID_STYLE
-import code.name.monkey.retromusic.HOME_ARTIST_GRID_STYLE
-import code.name.monkey.retromusic.IGNORE_MEDIA_STORE_ARTWORK
-import code.name.monkey.retromusic.INITIALIZED_BLACKLIST
-import code.name.monkey.retromusic.KEEP_SCREEN_ON
-import code.name.monkey.retromusic.LANGUAGE_NAME
-import code.name.monkey.retromusic.LAST_ADDED_CUTOFF
-import code.name.monkey.retromusic.LAST_CHANGELOG_VERSION
-import code.name.monkey.retromusic.LAST_PAGE
-import code.name.monkey.retromusic.LAST_SLEEP_TIMER_VALUE
-import code.name.monkey.retromusic.LIBRARY_CATEGORIES
-import code.name.monkey.retromusic.LOCK_SCREEN
-import code.name.monkey.retromusic.LYRICS_OPTIONS
-import code.name.monkey.retromusic.NEXT_SLEEP_TIMER_ELAPSED_REALTIME
-import code.name.monkey.retromusic.NOW_PLAYING_SCREEN_ID
-import code.name.monkey.retromusic.PAUSE_ON_ZERO_VOLUME
-import code.name.monkey.retromusic.PLAYLIST_SORT_ORDER
-import code.name.monkey.retromusic.R
-import code.name.monkey.retromusic.RECENTLY_PLAYED_CUTOFF
-import code.name.monkey.retromusic.SAF_SDCARD_URI
-import code.name.monkey.retromusic.SLEEP_TIMER_FINISH_SONG
-import code.name.monkey.retromusic.SONG_GRID_SIZE
-import code.name.monkey.retromusic.SONG_GRID_SIZE_LAND
-import code.name.monkey.retromusic.SONG_GRID_STYLE
-import code.name.monkey.retromusic.SONG_SORT_ORDER
-import code.name.monkey.retromusic.START_DIRECTORY
-import code.name.monkey.retromusic.TAB_TEXT_MODE
-import code.name.monkey.retromusic.TOGGLE_ADD_CONTROLS
-import code.name.monkey.retromusic.TOGGLE_FULL_SCREEN
-import code.name.monkey.retromusic.TOGGLE_HEADSET
-import code.name.monkey.retromusic.TOGGLE_HOME_BANNER
-import code.name.monkey.retromusic.TOGGLE_SHUFFLE
-import code.name.monkey.retromusic.TOGGLE_VOLUME
-import code.name.monkey.retromusic.USER_NAME
+import code.name.monkey.retromusic.*
 import code.name.monkey.retromusic.extensions.getIntRes
 import code.name.monkey.retromusic.extensions.getStringOrDefault
 import code.name.monkey.retromusic.fragments.AlbumCoverStyle
@@ -84,13 +15,7 @@ import code.name.monkey.retromusic.fragments.NowPlayingScreen
 import code.name.monkey.retromusic.fragments.folder.FoldersFragment
 import code.name.monkey.retromusic.helper.SortOrder.*
 import code.name.monkey.retromusic.model.CategoryInfo
-import code.name.monkey.retromusic.transform.CascadingPageTransformer
-import code.name.monkey.retromusic.transform.DepthTransformation
-import code.name.monkey.retromusic.transform.HingeTransformation
-import code.name.monkey.retromusic.transform.HorizontalFlipTransformation
-import code.name.monkey.retromusic.transform.NormalPageTransformer
-import code.name.monkey.retromusic.transform.VerticalFlipTransformation
-import code.name.monkey.retromusic.transform.VerticalStackTransformer
+import code.name.monkey.retromusic.transform.*
 import code.name.monkey.retromusic.util.theme.ThemeMode
 import com.google.android.material.bottomnavigation.LabelVisibilityMode
 import com.google.gson.Gson
@@ -183,13 +108,6 @@ object PreferenceUtil {
             putString(SAF_SDCARD_URI, value)
         }
 
-
-    val selectedEqualizer
-        get() = sharedPreferences.getStringOrDefault(
-            CHOOSE_EQUALIZER,
-            "system"
-        )
-
     val autoDownloadImagesPolicy
         get() = sharedPreferences.getStringOrDefault(
             AUTO_DOWNLOAD_IMAGES_POLICY,
@@ -458,11 +376,6 @@ object PreferenceUtil {
             putInt(LAST_SLEEP_TIMER_VALUE, value)
         }
 
-    var lastPage
-        get() = sharedPreferences.getInt(LAST_PAGE, R.id.action_song)
-        set(value) = sharedPreferences.edit {
-            putInt(LAST_PAGE, value)
-        }
 
     var nextSleepTimerElapsedRealTime
         get() = sharedPreferences.getInt(
@@ -639,32 +552,9 @@ object PreferenceUtil {
         }
 
     fun getRecentlyPlayedCutoffTimeMillis(): Long {
-        return getCutoffTimeMillis(RECENTLY_PLAYED_CUTOFF)
-    }
-
-    fun getRecentlyPlayedCutoffText(context: Context): String? {
-        return getCutoffText(RECENTLY_PLAYED_CUTOFF, context)
-    }
-
-    private fun getCutoffText(
-        cutoff: String,
-        context: Context
-    ): String? {
-        return when (sharedPreferences.getString(cutoff, "")) {
-            "today" -> context.getString(R.string.today)
-            "this_week" -> context.getString(R.string.this_week)
-            "past_seven_days" -> context.getString(R.string.past_seven_days)
-            "past_three_months" -> context.getString(R.string.past_three_months)
-            "this_year" -> context.getString(R.string.this_year)
-            "this_month" -> context.getString(R.string.this_month)
-            else -> context.getString(R.string.this_month)
-        }
-    }
-
-    private fun getCutoffTimeMillis(cutoff: String): Long {
         val calendarUtil = CalendarUtil()
         val interval: Long
-        interval = when (sharedPreferences.getString(cutoff, "")) {
+        interval = when (sharedPreferences.getString(RECENTLY_PLAYED_CUTOFF, "")) {
             "today" -> calendarUtil.elapsedToday
             "this_week" -> calendarUtil.elapsedWeek
             "past_seven_days" -> calendarUtil.getElapsedDays(7)
@@ -690,5 +580,4 @@ object PreferenceUtil {
                 }
             return (System.currentTimeMillis() - interval) / 1000
         }
-
 }