From 14f31eae372c15b9494ebb5e69abb28d4db30214 Mon Sep 17 00:00:00 2001 From: Prathamesh More Date: Sat, 28 May 2022 00:09:49 +0530 Subject: [PATCH] Fixed leaks in some fragments --- .../retromusic/activities/SupportDevelopmentActivity.kt | 2 +- .../monkey/retromusic/fragments/backup/BackupFragment.kt | 5 +++++ .../monkey/retromusic/fragments/genres/GenresFragment.kt | 1 + .../monkey/retromusic/fragments/other/LyricsFragment.kt | 6 ++++++ .../retromusic/fragments/settings/SettingsFragment.kt | 5 +++++ 5 files changed, 18 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/code/name/monkey/retromusic/activities/SupportDevelopmentActivity.kt b/app/src/main/java/code/name/monkey/retromusic/activities/SupportDevelopmentActivity.kt index b6420c8d2..377cbec93 100644 --- a/app/src/main/java/code/name/monkey/retromusic/activities/SupportDevelopmentActivity.kt +++ b/app/src/main/java/code/name/monkey/retromusic/activities/SupportDevelopmentActivity.kt @@ -174,7 +174,7 @@ class SkuDetailsAdapter( override fun onBindViewHolder(viewHolder: ViewHolder, i: Int) { val skuDetails = skuDetailsList[i] with(viewHolder.binding) { - itemTitle.text = skuDetails.title.replace("Retro Music Player MP3 Player", "") + itemTitle.text = skuDetails.title.replace("(Retro Music Player MP3 Player)", "") .trim { it <= ' ' } itemText.text = skuDetails.description itemText.isVisible = false diff --git a/app/src/main/java/code/name/monkey/retromusic/fragments/backup/BackupFragment.kt b/app/src/main/java/code/name/monkey/retromusic/fragments/backup/BackupFragment.kt index 304a02ec7..bb4a57ecb 100644 --- a/app/src/main/java/code/name/monkey/retromusic/fragments/backup/BackupFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/fragments/backup/BackupFragment.kt @@ -154,4 +154,9 @@ class BackupFragment : Fragment(R.layout.fragment_backup), BackupAdapter.BackupC } return false } + + override fun onDestroyView() { + super.onDestroyView() + _binding = null + } } \ No newline at end of file diff --git a/app/src/main/java/code/name/monkey/retromusic/fragments/genres/GenresFragment.kt b/app/src/main/java/code/name/monkey/retromusic/fragments/genres/GenresFragment.kt index 8ba01f9e5..58e11c403 100644 --- a/app/src/main/java/code/name/monkey/retromusic/fragments/genres/GenresFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/fragments/genres/GenresFragment.kt @@ -76,6 +76,7 @@ GenresFragment : AbsRecyclerViewFragment(), } + override val titleRes: Int get() = R.string.genres diff --git a/app/src/main/java/code/name/monkey/retromusic/fragments/other/LyricsFragment.kt b/app/src/main/java/code/name/monkey/retromusic/fragments/other/LyricsFragment.kt index 0083464b2..8792bc731 100644 --- a/app/src/main/java/code/name/monkey/retromusic/fragments/other/LyricsFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/fragments/other/LyricsFragment.kt @@ -425,11 +425,17 @@ class LyricsFragment : AbsMainActivityFragment(R.layout.fragment_lyrics) { super.onPause() updateHelper.stop() } + + override fun onDestroyView() { + super.onDestroyView() + _binding = null + } } override fun onDestroyView() { super.onDestroyView() if (MusicPlayerRemote.playingQueue.isNotEmpty()) (requireActivity() as MainActivity).expandPanel() + _binding = null } } diff --git a/app/src/main/java/code/name/monkey/retromusic/fragments/settings/SettingsFragment.kt b/app/src/main/java/code/name/monkey/retromusic/fragments/settings/SettingsFragment.kt index 88a48f29c..3c7d804df 100644 --- a/app/src/main/java/code/name/monkey/retromusic/fragments/settings/SettingsFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/fragments/settings/SettingsFragment.kt @@ -101,6 +101,11 @@ class SettingsFragment : AbsMusicServiceFragment(R.layout.fragment_settings), Co bottom = if (MusicPlayerRemote.playingQueue.isEmpty()) 0 else dip(R.dimen.mini_player_height)) } + override fun onDestroyView() { + super.onDestroyView() + _binding = null + } + companion object { val TAG: String = SettingsFragment::class.java.simpleName }