diff --git a/app/build.gradle b/app/build.gradle
index f9487b0e0..f92862ea9 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -51,7 +51,7 @@ android {
}
}
lint {
- disable 'MissingTranslation', 'ImpliedQuantity'
+ warning 'MissingTranslation', 'ImpliedQuantity', 'Instantiatable'
}
compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index dabe48036..697a4cb6f 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -13,7 +13,7 @@
+ android:maxSdkVersion="29" />
diff --git a/app/src/main/java/code/name/monkey/retromusic/activities/base/AbsMusicServiceActivity.kt b/app/src/main/java/code/name/monkey/retromusic/activities/base/AbsMusicServiceActivity.kt
index 59c6320d8..07937c7b5 100644
--- a/app/src/main/java/code/name/monkey/retromusic/activities/base/AbsMusicServiceActivity.kt
+++ b/app/src/main/java/code/name/monkey/retromusic/activities/base/AbsMusicServiceActivity.kt
@@ -191,7 +191,7 @@ abstract class AbsMusicServiceActivity : AbsBaseActivity(), IMusicServiceEventLi
override fun getPermissionsToRequest(): Array {
return mutableListOf(Manifest.permission.READ_EXTERNAL_STORAGE).apply {
- if (!VersionUtils.hasQ()) {
+ if (!VersionUtils.hasR()) {
add(Manifest.permission.WRITE_EXTERNAL_STORAGE)
}
}.toTypedArray()
diff --git a/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt b/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt
index f83b6f0d2..d4ac50db0 100644
--- a/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt
+++ b/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt
@@ -754,11 +754,11 @@ class MusicService : MediaBrowserServiceCompat(),
this.position = position
openCurrent { success ->
completion(success)
- notifyChange(META_CHANGED)
- notHandledMetaChangedForCurrentTrack = false
if (success) {
prepareNextImpl()
}
+ notifyChange(META_CHANGED)
+ notHandledMetaChangedForCurrentTrack = false
}
}
@@ -1088,11 +1088,9 @@ class MusicService : MediaBrowserServiceCompat(),
// We must call updateMediaSessionPlaybackState after the load of album art is completed
// if we are loading it or it won't be updated in the notification
updateMediaSessionMetaData(::updateMediaSessionPlaybackState)
+ savePosition()
+ savePositionInTrack()
serviceScope.launch(IO) {
- withContext(Main) {
- savePosition()
- savePositionInTrack()
- }
val currentSong = currentSong
HistoryStore.getInstance(this@MusicService).addSongId(currentSong.id)
if (songPlayCountHelper.shouldBumpPlayCount()) {