From 192b5c2ac7ac85e4922bb928b83bc87cf66bd007 Mon Sep 17 00:00:00 2001
From: Prathamesh More <prathameshmm02@gmail.com>
Date: Sat, 11 Jun 2022 19:02:00 +0530
Subject: [PATCH] Enabled WRITE_EXTERNAL_STORAGE for A10 to avoid crashes

---
 app/build.gradle                                       |  2 +-
 app/src/main/AndroidManifest.xml                       |  2 +-
 .../activities/base/AbsMusicServiceActivity.kt         |  2 +-
 .../name/monkey/retromusic/service/MusicService.kt     | 10 ++++------
 4 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/app/build.gradle b/app/build.gradle
index f9487b0e0..f92862ea9 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -51,7 +51,7 @@ android {
         }
     }
     lint {
-        disable 'MissingTranslation', 'ImpliedQuantity'
+        warning 'MissingTranslation', 'ImpliedQuantity', 'Instantiatable'
     }
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index dabe48036..697a4cb6f 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -13,7 +13,7 @@
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
     <uses-permission
         android:name="android.permission.WRITE_EXTERNAL_STORAGE"
-        android:maxSdkVersion="28" />
+        android:maxSdkVersion="29" />
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
     <uses-permission android:name="android.permission.BROADCAST_STICKY" />
diff --git a/app/src/main/java/code/name/monkey/retromusic/activities/base/AbsMusicServiceActivity.kt b/app/src/main/java/code/name/monkey/retromusic/activities/base/AbsMusicServiceActivity.kt
index 59c6320d8..07937c7b5 100644
--- a/app/src/main/java/code/name/monkey/retromusic/activities/base/AbsMusicServiceActivity.kt
+++ b/app/src/main/java/code/name/monkey/retromusic/activities/base/AbsMusicServiceActivity.kt
@@ -191,7 +191,7 @@ abstract class AbsMusicServiceActivity : AbsBaseActivity(), IMusicServiceEventLi
 
     override fun getPermissionsToRequest(): Array<String> {
         return mutableListOf(Manifest.permission.READ_EXTERNAL_STORAGE).apply {
-            if (!VersionUtils.hasQ()) {
+            if (!VersionUtils.hasR()) {
                 add(Manifest.permission.WRITE_EXTERNAL_STORAGE)
             }
         }.toTypedArray()
diff --git a/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt b/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt
index f83b6f0d2..d4ac50db0 100644
--- a/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt
+++ b/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt
@@ -754,11 +754,11 @@ class MusicService : MediaBrowserServiceCompat(),
         this.position = position
         openCurrent { success ->
             completion(success)
-            notifyChange(META_CHANGED)
-            notHandledMetaChangedForCurrentTrack = false
             if (success) {
                 prepareNextImpl()
             }
+            notifyChange(META_CHANGED)
+            notHandledMetaChangedForCurrentTrack = false
         }
     }
 
@@ -1088,11 +1088,9 @@ class MusicService : MediaBrowserServiceCompat(),
                 // We must call updateMediaSessionPlaybackState after the load of album art is completed
                 // if we are loading it or it won't be updated in the notification
                 updateMediaSessionMetaData(::updateMediaSessionPlaybackState)
+                savePosition()
+                savePositionInTrack()
                 serviceScope.launch(IO) {
-                    withContext(Main) {
-                        savePosition()
-                        savePositionInTrack()
-                    }
                     val currentSong = currentSong
                     HistoryStore.getInstance(this@MusicService).addSongId(currentSong.id)
                     if (songPlayCountHelper.shouldBumpPlayCount()) {