From 3aea91eb1e4917e71c4b47985b569c35ab0adf87 Mon Sep 17 00:00:00 2001 From: Prathamesh More Date: Sat, 11 Jun 2022 17:28:17 +0530 Subject: [PATCH] Safely show toasts in MusicService --- .../name/monkey/retromusic/service/MusicService.kt | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt b/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt index ee1db4f32..f83b6f0d2 100644 --- a/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt +++ b/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt @@ -796,7 +796,9 @@ class MusicService : MediaBrowserServiceCompat(), if (success) { play() } else { - showToast(resources.getString(R.string.unplayable_file)) + runOnUiThread { + showToast(R.string.unplayable_file) + } } } } @@ -1205,10 +1207,14 @@ class MusicService : MediaBrowserServiceCompat(), openQueue(playlistSongs, 0, true) } } else { - showToast(R.string.playlist_is_empty, Toast.LENGTH_LONG) + runOnUiThread { + showToast(R.string.playlist_is_empty, Toast.LENGTH_LONG) + } } } else { - showToast(R.string.playlist_is_empty, Toast.LENGTH_LONG) + runOnUiThread { + showToast(R.string.playlist_is_empty, Toast.LENGTH_LONG) + } } } @@ -1355,7 +1361,6 @@ class MusicService : MediaBrowserServiceCompat(), const val REPEAT_MODE_NONE = 0 const val REPEAT_MODE_ALL = 1 const val REPEAT_MODE_THIS = 2 - const val SAVE_QUEUES = 0 private const val MEDIA_SESSION_ACTIONS = (PlaybackStateCompat.ACTION_PLAY or PlaybackStateCompat.ACTION_PAUSE or PlaybackStateCompat.ACTION_PLAY_PAUSE