Edge-to-edge Code cleanup

app/src/main/java/code/name/monkey/retromusic/activities/LockScreenActivity.kt

@@ -41,7 +41,6 @@ class LockScreenActivity : AbsMusicServiceActivity() {
     private var fragment: LockScreenControlsFragment? = null
 
     override fun onCreate(savedInstanceState: Bundle?) {
-        setDrawUnderStatusBar()
         super.onCreate(savedInstanceState)
         lockScreenInit()
         binding = ActivityLockScreenBinding.inflate(layoutInflater)

app/src/main/java/code/name/monkey/retromusic/activities/MainActivity.kt

@@ -51,7 +51,6 @@ class MainActivity : AbsCastActivity(), OnSharedPreferenceChangeListener {
     }
 
     override fun onCreate(savedInstanceState: Bundle?) {
-        setDrawUnderStatusBar()
         super.onCreate(savedInstanceState)
         setTaskDescriptionColorAuto()
         hideStatusBar()

app/src/main/java/code/name/monkey/retromusic/activities/PurchaseActivity.kt

@@ -28,7 +28,6 @@ import code.name.monkey.retromusic.Constants.PRO_VERSION_PRODUCT_ID
 import code.name.monkey.retromusic.R
 import code.name.monkey.retromusic.activities.base.AbsBaseActivity
 import code.name.monkey.retromusic.databinding.ActivityProVersionBinding
-import code.name.monkey.retromusic.extensions.setDrawUnderStatusBar
 import code.name.monkey.retromusic.extensions.setLightStatusBar
 import code.name.monkey.retromusic.extensions.setStatusBarColor
 import com.anjlab.android.iab.v3.BillingProcessor
@@ -40,7 +39,6 @@ class PurchaseActivity : AbsBaseActivity(), BillingProcessor.IBillingHandler {
     private lateinit var billingProcessor: BillingProcessor
 
     override fun onCreate(savedInstanceState: Bundle?) {
-        setDrawUnderStatusBar()
         super.onCreate(savedInstanceState)
         binding = ActivityProVersionBinding.inflate(layoutInflater)
         setContentView(binding.root)

app/src/main/java/code/name/monkey/retromusic/activities/SettingsActivity.kt

@@ -32,7 +32,6 @@ import com.afollestad.materialdialogs.color.ColorCallback
 class SettingsActivity : AbsThemeActivity(), ColorCallback, OnThemeChangedListener {
     private lateinit var binding: ActivitySettingsBinding
     override fun onCreate(savedInstanceState: Bundle?) {
-        setDrawUnderStatusBar()
         val mSavedInstanceState = extra<Bundle>(TAG).value ?: savedInstanceState
         super.onCreate(mSavedInstanceState)
         setLightStatusBarAuto(surfaceColor())

app/src/main/java/code/name/monkey/retromusic/activities/ShareInstagramStory.kt

@@ -28,8 +28,6 @@ import code.name.monkey.appthemehelper.util.ColorUtil
 import code.name.monkey.appthemehelper.util.MaterialValueHelper
 import code.name.monkey.retromusic.activities.base.AbsBaseActivity
 import code.name.monkey.retromusic.databinding.ActivityShareInstagramBinding
-import code.name.monkey.retromusic.extensions.applyToolbar
-import code.name.monkey.retromusic.extensions.setDrawUnderStatusBar
 import code.name.monkey.retromusic.extensions.setLightStatusBar
 import code.name.monkey.retromusic.extensions.setStatusBarColor
 import code.name.monkey.retromusic.glide.GlideApp
@@ -60,7 +58,6 @@ class ShareInstagramStory : AbsBaseActivity() {
     }
 
     override fun onCreate(savedInstanceState: Bundle?) {
-        setDrawUnderStatusBar()
         super.onCreate(savedInstanceState)
         binding = ActivityShareInstagramBinding.inflate(layoutInflater)
         setContentView(binding.root)

app/src/main/java/code/name/monkey/retromusic/activities/base/AbsThemeActivity.kt

@@ -35,6 +35,7 @@ abstract class AbsThemeActivity : ATHToolbarActivity(), Runnable {
     private val handler = Handler()
 
     override fun onCreate(savedInstanceState: Bundle?) {
+        setDrawBehindSystemBars()
         updateTheme()
         hideStatusBar()
         super.onCreate(savedInstanceState)

app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AlbumTagEditorActivity.kt

@@ -32,7 +32,6 @@ import code.name.monkey.appthemehelper.util.ATHUtil
 import code.name.monkey.retromusic.R
 import code.name.monkey.retromusic.databinding.ActivityAlbumTagEditorBinding
 import code.name.monkey.retromusic.extensions.appHandleColor
-import code.name.monkey.retromusic.extensions.setDrawUnderStatusBar
 import code.name.monkey.retromusic.extensions.setTint
 import code.name.monkey.retromusic.glide.GlideApp
 import code.name.monkey.retromusic.glide.palette.BitmapPaletteWrapper
@@ -109,7 +108,6 @@ class AlbumTagEditorActivity : AbsTagEditorActivity<ActivityAlbumTagEditorBindin
     }
 
     override fun onCreate(savedInstanceState: Bundle?) {
-        setDrawUnderStatusBar()
         super.onCreate(savedInstanceState)
         window.sharedElementsUseOverlay = true
         binding.imageContainer.transitionName = getString(R.string.transition_album_art)

app/src/main/java/code/name/monkey/retromusic/extensions/ActivityThemeExtensions.kt

@@ -11,13 +11,11 @@ import androidx.core.view.WindowInsetsCompat
 import androidx.core.view.WindowInsetsControllerCompat
 import androidx.fragment.app.FragmentActivity
 import code.name.monkey.appthemehelper.ATH
-import code.name.monkey.appthemehelper.ThemeStore
 import code.name.monkey.appthemehelper.util.ATHUtil
 import code.name.monkey.appthemehelper.util.ColorUtil
 import code.name.monkey.appthemehelper.util.VersionUtils
 import code.name.monkey.retromusic.R
 import code.name.monkey.retromusic.util.PreferenceUtil
-import code.name.monkey.retromusic.util.RetroUtil
 
 fun AppCompatActivity.toggleScreenOn() {
     if (PreferenceUtil.isScreenOnEnabled) {
@@ -60,9 +58,13 @@ private fun AppCompatActivity.hideStatusBar(fullscreen: Boolean) {
     }
 }
 
-fun AppCompatActivity.setDrawUnderStatusBar() {
+fun AppCompatActivity.setDrawBehindSystemBars() {
     WindowCompat.setDecorFitsSystemWindows(window, false)
     window.statusBarColor = Color.TRANSPARENT
+    window.navigationBarColor = Color.TRANSPARENT
+    if (VersionUtils.hasQ()) {
+        window.isNavigationBarContrastEnforced = false
+    }
 }
 
 fun FragmentActivity.setTaskDescriptionColor(color: Int) {
@@ -100,9 +102,7 @@ fun AppCompatActivity.setLightStatusBarAuto(bgColor: Int) {
 }
 
 fun AppCompatActivity.setLightNavigationBar(enabled: Boolean) {
-    if (!ATHUtil.isWindowBackgroundDark(this) and ThemeStore.coloredNavigationBar(this)) {
+   ATH.setLightNavigationBar(this, enabled)
-        ATH.setLightNavigationBar(this, enabled)
-    }
 }
 
 

app/src/main/res/layout/fragment_album_content.xml

@@ -62,7 +62,7 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/songTitle"
-        tools:listitem="@layout/item_song" />
+        tools:listitem="@layout/item_song"/>
 
     <com.google.android.material.textview.MaterialTextView
         android:id="@+id/moreTitle"

app/src/main/res/layout/fragment_lock_screen_playback_controls.xml

@@ -28,6 +28,7 @@
         android:id="@+id/progressSlider"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
+        android:layout_marginTop="8dp"
         android:maxHeight="2dp"
         android:progressDrawable="@drawable/color_progress_seek"
         app:layout_constraintEnd_toStartOf="@id/songTotalTime"

appthemehelper/src/main/java/code/name/monkey/appthemehelper/ATH.kt

@@ -36,7 +36,6 @@ object ATH {
 
     fun setLightNavigationBar(activity: Activity, enabled: Boolean) {
         activity.window.apply {
-            navigationBarColor = Color.TRANSPARENT
             WindowInsetsControllerCompat(
                 this,
                 decorView

appthemehelper/src/main/java/code/name/monkey/appthemehelper/util/ATHUtil.kt

@@ -2,6 +2,7 @@ package code.name.monkey.appthemehelper.util
 
 import android.content.Context
 import androidx.annotation.AttrRes
+import androidx.core.content.res.use
 
 /**
  * @author Aidan Follestad (afollestad)
@@ -14,11 +15,8 @@ object ATHUtil {
 
     @JvmOverloads
     fun resolveColor(context: Context, @AttrRes attr: Int, fallback: Int = 0): Int {
-        val a = context.theme.obtainStyledAttributes(intArrayOf(attr))
+        context.theme.obtainStyledAttributes(intArrayOf(attr)).use {
-        try {
+            return it.getColor(0, fallback)
-            return a.getColor(0, fallback)
-        } finally {
-            a.recycle()
         }
     }
 }

gradle.properties

@@ -1,10 +1,21 @@
-org.gradle.jvmargs=-Xmx4608m
+# Project-wide Gradle settings.
-org.gradle.daemon=true
+# IDE (e.g. Android Studio) users:
+# Gradle settings configured through the IDE *will override*
+# any settings specified in this file.
+# For more details on how to configure your build environment visit
+# http://www.gradle.org/docs/current/userguide/build_environment.html
+# Specifies the JVM arguments used for the daemon process.
+# The setting is particularly useful for tweaking memory settings.
+org.gradle.jvmargs=-Xmx2048m -Dfile.encoding=UTF-8
+# When configured, Gradle will run in incubating parallel mode.
+# This option should only be used with decoupled projects. More details, visit
+# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
 org.gradle.parallel=true
-jvmArgs='-Xmx2048m'
+# AndroidX package structure to make it clearer which packages are bundled with the
+# Android operating system, and which are packaged with your app"s APK
+# https://developer.android.com/topic/libraries/support-library/androidx-rn
 android.useAndroidX=true
-android.enabelR8=true
+# Automatically convert third-party libraries to use AndroidX
-android.enableR8.fullMode=false
 android.enableJetifier=true
-android.debug.obsoleteApi=true
+# Kotlin code style for this project: "official" or "obsolete":
 kotlin.code.style=official