Siklos/Metro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #1271 from AgarwalsRahul/Fix-#1270

Browse source 
Fix screen rotation issue in permission activity layout
This commit is contained in:
Prathamesh More 2022-03-03 09:24:28 +05:30 • committed by GitHub
commit 633e5e446c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 46 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

31
app/src/main/res/layout/activity_permission.xml
View file

@ -29,13 +29,25 @@
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/appNameText" /> app:layout_constraintTop_toBottomOf="@id/appNameText" />
<code.name.monkey.retromusic.views.PermissionItem <ScrollView
android:id="@+id/storagePermission" android:layout_width="match_parent"
android:layout_width="0dp" android:layout_height="0dp"
android:layout_height="wrap_content" android:fillViewport="true"
app:layout_constraintBottom_toTopOf="@+id/finish"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/divider" app:layout_constraintTop_toBottomOf="@+id/divider">
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="@integer/permission_orientation">
<code.name.monkey.retromusic.views.PermissionItem
android:id="@+id/storagePermission"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_weight="@integer/permission_layout_weight"
app:permissionButtonTitle="Grant access" app:permissionButtonTitle="Grant access"
app:permissionIcon="@drawable/ic_sd_storage" app:permissionIcon="@drawable/ic_sd_storage"
app:permissionTitle="@string/permission_title" app:permissionTitle="@string/permission_title"
@ -44,18 +56,19 @@
<code.name.monkey.retromusic.views.PermissionItem <code.name.monkey.retromusic.views.PermissionItem
android:id="@+id/audioPermission" android:id="@+id/audioPermission"
android:layout_width="0dp" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:visibility="gone" android:visibility="gone"
app:layout_constraintEnd_toEndOf="parent" android:layout_weight="@integer/permission_layout_weight"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/storagePermission"
app:permissionButtonTitle="Grant access" app:permissionButtonTitle="Grant access"
app:permissionIcon="@drawable/ic_phonelink_ring" app:permissionIcon="@drawable/ic_phonelink_ring"
app:permissionTitle="@string/ringtone_title" app:permissionTitle="@string/ringtone_title"
app:permissionTitleNumber="2" app:permissionTitleNumber="2"
app:permissionTitleSubTitle="@string/ringtone_summary" app:permissionTitleSubTitle="@string/ringtone_summary"
tools:visibility="visible" /> tools:visibility="visible" />
</LinearLayout>
</ScrollView>
<com.google.android.material.button.MaterialButton <com.google.android.material.button.MaterialButton
android:id="@+id/finish" android:id="@+id/finish"

5
app/src/main/res/values-land/integers.xml Normal file
View file

@ -0,0 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<integer name="permission_orientation">0</integer>
<integer name="permission_layout_weight">1</integer>
</resources>

2
app/src/main/res/values-sw600dp/integers.xml
View file

@ -8,4 +8,6 @@
<integer name="max_columns">6</integer> <integer name="max_columns">6</integer>
<integer name="max_columns_land">8</integer> <integer name="max_columns_land">8</integer>
<integer name="permission_orientation">1</integer>
<integer name="permission_layout_weight">1</integer>
</resources> </resources>

2
app/src/main/res/values/integers.xml
View file

@ -10,4 +10,6 @@
<integer name="max_columns_land">6</integer> <integer name="max_columns_land">6</integer>
<integer name="anim_duration_medium">200</integer> <integer name="anim_duration_medium">200</integer>
<integer name="permission_orientation">1</integer>
<integer name="permission_layout_weight">0</integer>
</resources> </resources>