From 8682b1c09f73f7e429e24b5ff570b747f88790da Mon Sep 17 00:00:00 2001
From: Goooler <wangzongler@gmail.com>
Date: Fri, 22 Jul 2022 15:27:00 +0800
Subject: [PATCH] Use debug signingConfig if retro.properties doesn't exist

---
 .github/workflows/android.yml | 11 -----------
 app/build.gradle              | 28 +++++++++++++++++-----------
 2 files changed, 17 insertions(+), 22 deletions(-)

diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
index 2c5b0123d..5508155e5 100644
--- a/.github/workflows/android.yml
+++ b/.github/workflows/android.yml
@@ -19,16 +19,5 @@ jobs:
         java-version: '11'
         distribution: 'temurin'
     - uses: gradle/gradle-build-action@v2
-
-    - name: Generate temporary keystore
-      run: keytool -genkey -v -storetype pkcs12 -keystore store.p12 -storepass android -alias android -keyalg RSA -keysize 2048 -validity 10000 -dname CN=CI
-    - name: Write retro.properties
-      run: |
-        cat >retro.properties <<EOF
-        storeFile=$PWD/store.p12
-        keyAlias=android
-        storePassword=android
-        keyPassword=android
-        EOF
     - name: Build with Gradle
       run: ./gradlew build
diff --git a/app/build.gradle b/app/build.gradle
index ac36a81fb..2709c1a8b 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -20,23 +20,27 @@ android {
 
         buildConfigField("String", "GOOGLE_PLAY_LICENSING_KEY", "\"${getProperty(getProperties('../public.properties'), 'GOOGLE_PLAY_LICENSE_KEY')}\"")
     }
-    signingConfigs {
-        release {
-            Properties properties = getProperties('retro.properties')
-            storeFile file(getProperty(properties, 'storeFile'))
-            keyAlias getProperty(properties, 'keyAlias')
-            storePassword getProperty(properties, 'storePassword')
-            keyPassword getProperty(properties, 'keyPassword')
+    def signingProperties = getProperties('retro.properties')
+    def releaseSigning
+    if (signingProperties != null) {
+        releaseSigning = signingConfigs.create("release") {
+            storeFile file(getProperty(signingProperties, 'storeFile'))
+            keyAlias getProperty(signingProperties, 'keyAlias')
+            storePassword getProperty(signingProperties, 'storePassword')
+            keyPassword getProperty(signingProperties, 'keyPassword')
         }
+    } else {
+        releaseSigning = signingConfigs.debug
     }
     buildTypes {
         release {
             shrinkResources true
             minifyEnabled true
             proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
-            signingConfig signingConfigs.release
+            signingConfig releaseSigning
         }
         debug {
+            signingConfig releaseSigning
             applicationIdSuffix '.debug'
             versionNameSuffix ' DEBUG'
         }
@@ -51,7 +55,7 @@ android {
         }
     }
 
-    buildFeatures{
+    buildFeatures {
         viewBinding true
     }
     packagingOptions {
@@ -76,16 +80,18 @@ android {
 }
 
 def getProperties(String fileName) {
-    final Properties properties = new Properties()
+    Properties properties = new Properties()
     def file = rootProject.file(fileName)
     if (file.exists()) {
         file.withInputStream { stream -> properties.load(stream) }
+    } else {
+        properties = null
     }
     return properties
 }
 
 static def getProperty(Properties properties, String name) {
-    return properties.getProperty(name) ?: "$name missing"
+    return properties?.getProperty(name) ?: "$name missing"
 }
 
 dependencies {