From da0a4d5c13679b5869f7cfa214c8224fa40e3763 Mon Sep 17 00:00:00 2001 From: Prathamesh More Date: Mon, 30 May 2022 19:34:43 +0530 Subject: [PATCH] Fixed Now playing viewpager lag --- .../fragments/player/PlayerAlbumCoverFragment.kt | 7 ++++--- .../name/monkey/retromusic/model/CategoryInfo.kt | 1 - .../name/monkey/retromusic/service/MusicService.kt | 13 ------------- 3 files changed, 4 insertions(+), 17 deletions(-) diff --git a/app/src/main/java/code/name/monkey/retromusic/fragments/player/PlayerAlbumCoverFragment.kt b/app/src/main/java/code/name/monkey/retromusic/fragments/player/PlayerAlbumCoverFragment.kt index 79058d010..42fa58d3f 100644 --- a/app/src/main/java/code/name/monkey/retromusic/fragments/player/PlayerAlbumCoverFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/fragments/player/PlayerAlbumCoverFragment.kt @@ -183,7 +183,9 @@ class PlayerAlbumCoverFragment : AbsMusicServiceFragment(R.layout.fragment_playe override fun onPlayingMetaChanged() { logD("Playing Meta Changed") - viewPager.setCurrentItem(MusicPlayerRemote.position, true) + if (viewPager.currentItem != MusicPlayerRemote.position) { + viewPager.setCurrentItem(MusicPlayerRemote.position, true) + } updateLyrics() } @@ -260,8 +262,7 @@ class PlayerAlbumCoverFragment : AbsMusicServiceFragment(R.layout.fragment_playe } } - override fun onPageScrolled(position: Int, positionOffset: Float, positionOffsetPixels: Int) { - } + override fun onPageScrolled(position: Int, positionOffset: Float, positionOffsetPixels: Int) {} override fun onPageSelected(position: Int) { currentPosition = position diff --git a/app/src/main/java/code/name/monkey/retromusic/model/CategoryInfo.kt b/app/src/main/java/code/name/monkey/retromusic/model/CategoryInfo.kt index 78e6a1966..19218e9c3 100644 --- a/app/src/main/java/code/name/monkey/retromusic/model/CategoryInfo.kt +++ b/app/src/main/java/code/name/monkey/retromusic/model/CategoryInfo.kt @@ -22,7 +22,6 @@ import kotlinx.parcelize.Parcelize @Parcelize data class CategoryInfo( val category: Category, - @get:JvmName("isVisible") var visible: Boolean ) : Parcelable { diff --git a/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt b/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt index 3221a24f0..56e707073 100644 --- a/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt +++ b/app/src/main/java/code/name/monkey/retromusic/service/MusicService.kt @@ -1376,18 +1376,5 @@ class MusicService : MediaBrowserServiceCompat(), or PlaybackStateCompat.ACTION_SKIP_TO_PREVIOUS or PlaybackStateCompat.ACTION_STOP or PlaybackStateCompat.ACTION_SEEK_TO) - - private fun copy(bitmap: Bitmap): Bitmap? { - var config = bitmap.config - if (config == null) { - config = Bitmap.Config.RGB_565 - } - return try { - bitmap.copy(config, false) - } catch (e: OutOfMemoryError) { - e.printStackTrace() - null - } - } } } \ No newline at end of file