diff --git a/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AbsTagEditorActivity.kt b/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AbsTagEditorActivity.kt index 06d3c8396..a51a8976f 100755 --- a/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AbsTagEditorActivity.kt +++ b/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AbsTagEditorActivity.kt @@ -19,6 +19,7 @@ import code.name.monkey.appthemehelper.util.ColorUtil import code.name.monkey.appthemehelper.util.MaterialValueHelper import code.name.monkey.appthemehelper.util.TintHelper import code.name.monkey.retromusic.R +import code.name.monkey.retromusic.R.drawable import code.name.monkey.retromusic.activities.base.AbsBaseActivity import code.name.monkey.retromusic.activities.saf.SAFGuideActivity import code.name.monkey.retromusic.util.PreferenceUtil @@ -321,7 +322,7 @@ abstract class AbsTagEditorActivity : AbsBaseActivity() { protected fun setImageBitmap(bitmap: Bitmap?, bgColor: Int) { if (bitmap == null) { - editorImage.setImageResource(code.name.monkey.retromusic.R.drawable.default_album_art) + editorImage.setImageResource(drawable.default_album_art) } else { editorImage.setImageBitmap(bitmap) } @@ -414,4 +415,5 @@ abstract class AbsTagEditorActivity : AbsBaseActivity() { private val TAG = AbsTagEditorActivity::class.java.simpleName private const val REQUEST_CODE_SELECT_IMAGE = 1000 } + } diff --git a/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AlbumTagEditorActivity.kt b/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AlbumTagEditorActivity.kt index 90257de71..e6da7f915 100755 --- a/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AlbumTagEditorActivity.kt +++ b/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AlbumTagEditorActivity.kt @@ -9,7 +9,6 @@ import android.graphics.drawable.Drawable import android.net.Uri import android.os.Bundle import android.text.Editable -import android.text.TextUtils import android.text.TextWatcher import android.transition.Slide import android.widget.Toast @@ -22,9 +21,7 @@ import code.name.monkey.retromusic.glide.palette.BitmapPaletteTranscoder import code.name.monkey.retromusic.glide.palette.BitmapPaletteWrapper import code.name.monkey.retromusic.loaders.AlbumLoader import code.name.monkey.retromusic.rest.LastFMRestClient -import code.name.monkey.retromusic.rest.model.LastFmAlbum import code.name.monkey.retromusic.util.ImageUtil -import code.name.monkey.retromusic.util.LastFMUtil import code.name.monkey.retromusic.util.RetroColorUtil.generatePalette import code.name.monkey.retromusic.util.RetroColorUtil.getColor import com.bumptech.glide.Glide @@ -151,62 +148,6 @@ class AlbumTagEditorActivity : AbsTagEditorActivity(), TextWatcher { disposable.clear() } - private fun extractDetails(lastFmAlbum: LastFmAlbum) { - if (lastFmAlbum.album != null) { - - val url = LastFMUtil.getLargestAlbumImageUrl(lastFmAlbum.album.image) - - if (!TextUtils.isEmpty(url) && url.trim { it <= ' ' }.isNotEmpty()) { - Glide.with(this@AlbumTagEditorActivity).load(url).asBitmap() - .transcode(BitmapPaletteTranscoder(this), BitmapPaletteWrapper::class.java) - .diskCacheStrategy(DiskCacheStrategy.SOURCE).error(R.drawable.default_album_art) - .into(object : SimpleTarget() { - override fun onLoadFailed( - e: java.lang.Exception?, - errorDrawable: Drawable? - ) { - super.onLoadFailed(e, errorDrawable) - Toast.makeText( - this@AlbumTagEditorActivity, - e.toString(), - Toast.LENGTH_LONG - ).show() - } - - override fun onResourceReady( - resource: BitmapPaletteWrapper?, - glideAnimation: GlideAnimation? - ) { - albumArtBitmap = resource?.bitmap?.let { - ImageUtil.resizeBitmap( - it, - 2048 - ) - } - setImageBitmap( - albumArtBitmap, - getColor( - resource?.palette, - ATHUtil.resolveColor( - this@AlbumTagEditorActivity, - R.attr.defaultFooterColor - ) - ) - ) - deleteAlbumArt = false - dataChanged() - setResult(RESULT_OK) - } - }) - return - } - if (lastFmAlbum.album.tags.tag.size > 0) { - genreTitle.setText(lastFmAlbum.album.tags.tag[0].name) - } - } - toastLoadingFailed() - } - private fun toastLoadingFailed() { Toast.makeText( this@AlbumTagEditorActivity, @@ -237,8 +178,8 @@ class AlbumTagEditorActivity : AbsTagEditorActivity(), TextWatcher { fieldKeyValueMap[FieldKey.GENRE] = genreTitle.text.toString() fieldKeyValueMap[FieldKey.YEAR] = yearTitle.text.toString() - writeValuesToFiles( - fieldKeyValueMap, if (deleteAlbumArt) ArtworkInfo(id, null) + writeValuesToFiles(fieldKeyValueMap, + if (deleteAlbumArt) ArtworkInfo(id, null) else if (albumArtBitmap == null) null else ArtworkInfo(id, albumArtBitmap!!) ) } diff --git a/app/src/main/java/code/name/monkey/retromusic/fragments/settings/AbsSettingsFragment.kt b/app/src/main/java/code/name/monkey/retromusic/fragments/settings/AbsSettingsFragment.kt index e19316f38..97b96baa8 100644 --- a/app/src/main/java/code/name/monkey/retromusic/fragments/settings/AbsSettingsFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/fragments/settings/AbsSettingsFragment.kt @@ -37,7 +37,6 @@ import code.name.monkey.retromusic.preferences.MaterialListPreferenceDialog import code.name.monkey.retromusic.preferences.NowPlayingScreenPreference import code.name.monkey.retromusic.preferences.NowPlayingScreenPreferenceDialog import code.name.monkey.retromusic.util.NavigationUtil -import me.everything.android.ui.overscroll.OverScrollDecoratorHelper /** * @author Hemanth S (h4h13). @@ -80,7 +79,6 @@ abstract class AbsSettingsFragment : ATEPreferenceFragmentCompat() { listView.setPadding(0, 0, 0, 0) listView.setPaddingRelative(0, 0, 0, 0) invalidateSettings() - OverScrollDecoratorHelper.setUpOverScroll(listView, OverScrollDecoratorHelper.ORIENTATION_VERTICAL) } override fun onCreatePreferenceDialog(preference: Preference): DialogFragment? { diff --git a/app/src/main/java/code/name/monkey/retromusic/misc/UpdateToastMediaScannerCompletionListener.java b/app/src/main/java/code/name/monkey/retromusic/misc/UpdateToastMediaScannerCompletionListener.java index aaeda9e7c..98b52dd11 100644 --- a/app/src/main/java/code/name/monkey/retromusic/misc/UpdateToastMediaScannerCompletionListener.java +++ b/app/src/main/java/code/name/monkey/retromusic/misc/UpdateToastMediaScannerCompletionListener.java @@ -19,21 +19,26 @@ import android.app.Activity; import android.media.MediaScannerConnection; import android.net.Uri; import android.widget.Toast; - -import java.lang.ref.WeakReference; - import code.name.monkey.retromusic.R; +import java.lang.ref.WeakReference; /** * @author Karim Abou Zeid (kabouzeid) */ public class UpdateToastMediaScannerCompletionListener implements MediaScannerConnection.OnScanCompletedListener { - private final String[] toBeScanned; - private final String scannedFiles; - private final String couldNotScanFiles; + private final WeakReference activityWeakReference; - private int scanned = 0; + + private final String couldNotScanFiles; + private int failed = 0; + + private int scanned = 0; + + private final String scannedFiles; + + private final String[] toBeScanned; + private Toast toast; @SuppressLint("ShowToast") @@ -55,7 +60,8 @@ public class UpdateToastMediaScannerCompletionListener implements MediaScannerCo } else { scanned++; } - String text = " " + String.format(scannedFiles, scanned, toBeScanned.length) + (failed > 0 ? " " + String.format(couldNotScanFiles, failed) : ""); + String text = " " + String.format(scannedFiles, scanned, toBeScanned.length) + (failed > 0 ? " " + + String.format(couldNotScanFiles, failed) : ""); toast.setText(text); toast.show(); }); diff --git a/app/src/main/res/drawable-v21/round_selector.xml b/app/src/main/res/drawable-v21/round_selector.xml deleted file mode 100644 index c38d4e9cd..000000000 --- a/app/src/main/res/drawable-v21/round_selector.xml +++ /dev/null @@ -1,8 +0,0 @@ - - - - - \ No newline at end of file diff --git a/app/src/main/res/drawable-v21/round_selector_dark.xml b/app/src/main/res/drawable-v21/round_selector_dark.xml deleted file mode 100644 index 6499f8972..000000000 --- a/app/src/main/res/drawable-v21/round_selector_dark.xml +++ /dev/null @@ -1,8 +0,0 @@ - - - - - \ No newline at end of file diff --git a/app/src/main/res/drawable/rect_selector.xml b/app/src/main/res/drawable/rect_selector.xml index 1f8618481..b47709199 100644 --- a/app/src/main/res/drawable/rect_selector.xml +++ b/app/src/main/res/drawable/rect_selector.xml @@ -1,9 +1,24 @@ + + + android:color="?android:attr/colorControlHighlight"> + - + @@ -14,16 +29,6 @@ - - - - - - - - - - \ No newline at end of file diff --git a/app/src/main/res/drawable/round_selected.xml b/app/src/main/res/drawable/round_selected.xml deleted file mode 100644 index 0a18d9963..000000000 --- a/app/src/main/res/drawable/round_selected.xml +++ /dev/null @@ -1,5 +0,0 @@ - - - - \ No newline at end of file diff --git a/app/src/main/res/drawable/round_selected_dark.xml b/app/src/main/res/drawable/round_selected_dark.xml deleted file mode 100644 index 5f6350ed5..000000000 --- a/app/src/main/res/drawable/round_selected_dark.xml +++ /dev/null @@ -1,5 +0,0 @@ - - - - \ No newline at end of file diff --git a/app/src/main/res/drawable/round_selector.xml b/app/src/main/res/drawable/round_selector.xml index 77f09a4c0..c38d4e9cd 100644 --- a/app/src/main/res/drawable/round_selector.xml +++ b/app/src/main/res/drawable/round_selector.xml @@ -1,7 +1,8 @@ - - + - - + - \ No newline at end of file + \ No newline at end of file diff --git a/app/src/main/res/drawable/round_selector_dark.xml b/app/src/main/res/drawable/round_selector_dark.xml deleted file mode 100644 index d17201841..000000000 --- a/app/src/main/res/drawable/round_selector_dark.xml +++ /dev/null @@ -1,7 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/app/src/main/res/layout-land/pager_item.xml b/app/src/main/res/layout-land/pager_item.xml index e11370d3b..b834b7791 100644 --- a/app/src/main/res/layout-land/pager_item.xml +++ b/app/src/main/res/layout-land/pager_item.xml @@ -5,6 +5,7 @@ android:id="@+id/root_layout" android:layout_width="match_parent" android:layout_height="wrap_content" + android:background="?attr/rectSelector" android:orientation="vertical"> + android:scaleType="centerCrop" + tools:src="@tools:sample/avatars" /> + android:scaleType="centerCrop" + tools:src="@tools:sample/avatars" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_artist.xml b/app/src/main/res/layout/item_artist.xml index d55de701d..2c66d2361 100644 --- a/app/src/main/res/layout/item_artist.xml +++ b/app/src/main/res/layout/item_artist.xml @@ -5,6 +5,7 @@ android:layout_width="106dp" android:layout_height="wrap_content" android:layout_margin="8dp" + android:background="?attr/rectSelector" android:orientation="vertical"> diff --git a/app/src/main/res/layout/item_card.xml b/app/src/main/res/layout/item_card.xml index 70cd95c12..5f3ce430c 100644 --- a/app/src/main/res/layout/item_card.xml +++ b/app/src/main/res/layout/item_card.xml @@ -1,60 +1,68 @@ - - - - - - - - + android:layout_height="wrap_content" + app:cardCornerRadius="8dp" + app:cardUseCompatPadding="true" + tools:ignore="MissingPrefix"> + tools:ignore="UnusedAttribute,UselessParent"> - + + + + + + + android:gravity="center_vertical" + android:orientation="vertical" + android:padding="12dp"> - + + + + - - + + diff --git a/app/src/main/res/layout/item_card_color.xml b/app/src/main/res/layout/item_card_color.xml index 6a83f4532..c298e78a3 100644 --- a/app/src/main/res/layout/item_card_color.xml +++ b/app/src/main/res/layout/item_card_color.xml @@ -1,60 +1,69 @@ - - - - - - - - + android:layout_height="wrap_content" + app:cardCornerRadius="8dp" + app:cardUseCompatPadding="true" + tools:ignore="MissingPrefix"> + tools:ignore="UnusedAttribute,UselessParent"> - + - + + + + + android:gravity="center_vertical" + android:orientation="vertical" + android:padding="12dp"> + + + + + - - + + \ No newline at end of file diff --git a/app/src/main/res/layout/item_contributor.xml b/app/src/main/res/layout/item_contributor.xml index 2414408aa..bd589fc9a 100644 --- a/app/src/main/res/layout/item_contributor.xml +++ b/app/src/main/res/layout/item_contributor.xml @@ -17,7 +17,7 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?selectableItemBackground" + android:background="?rectSelector" android:gravity="center_vertical" android:minHeight="64dp" android:orientation="horizontal" diff --git a/app/src/main/res/layout/item_contributor_header.xml b/app/src/main/res/layout/item_contributor_header.xml index 188392564..7fd443d59 100644 --- a/app/src/main/res/layout/item_contributor_header.xml +++ b/app/src/main/res/layout/item_contributor_header.xml @@ -16,7 +16,7 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?selectableItemBackground" + android:background="?rectSelector" android:gravity="center_horizontal" android:minHeight="@dimen/md_listitem_height" android:orientation="vertical" diff --git a/app/src/main/res/layout/item_donation_option.xml b/app/src/main/res/layout/item_donation_option.xml index 8e061e316..03cf1cfbc 100644 --- a/app/src/main/res/layout/item_donation_option.xml +++ b/app/src/main/res/layout/item_donation_option.xml @@ -16,6 +16,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_gravity="center" + android:background="?rectSelector" android:gravity="center" android:orientation="vertical"> diff --git a/app/src/main/res/layout/item_grid.xml b/app/src/main/res/layout/item_grid.xml index ecca223fe..fa4d6431f 100644 --- a/app/src/main/res/layout/item_grid.xml +++ b/app/src/main/res/layout/item_grid.xml @@ -4,10 +4,10 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="4dp" + android:layout_margin="2dp" + android:background="?rectSelector" android:clickable="true" android:focusable="true" - android:foreground="?rectSelector" tools:ignore="MissingPrefix"> diff --git a/app/src/main/res/layout/item_image.xml b/app/src/main/res/layout/item_image.xml index f463a98ef..8319485c0 100644 --- a/app/src/main/res/layout/item_image.xml +++ b/app/src/main/res/layout/item_image.xml @@ -4,6 +4,7 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="wrap_content" android:layout_height="wrap_content" + android:background="?rectSelector" android:orientation="vertical"> - + android:layout_margin="2dp" + android:background="?attr/rectSelector" + android:clickable="true" + android:focusable="true" + tools:ignore="MissingPrefix"> - + android:layout_height="wrap_content" + android:orientation="vertical" + app:cardCornerRadius="8dp" + app:cardUseCompatPadding="true"> - - - - + android:layout_height="match_parent" + android:scaleType="centerCrop" + android:transitionName="@string/transition_album_art" + tools:ignore="ContentDescription" + tools:src="@tools:sample/avatars" /> - - - + android:layout_height="match_parent" + android:orientation="vertical"> + + + + + + - + - \ No newline at end of file + + \ No newline at end of file diff --git a/app/src/main/res/layout/item_list.xml b/app/src/main/res/layout/item_list.xml index 4f8dc4fdf..e40d0b939 100755 --- a/app/src/main/res/layout/item_list.xml +++ b/app/src/main/res/layout/item_list.xml @@ -4,14 +4,12 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginStart="2dp" + android:layout_marginEnd="2dp" android:layout_marginBottom="2dp" - android:layout_marginEnd="4dp" - android:layout_marginStart="4dp" - android:layout_marginTop="2dp" + android:background="?rectSelector" android:clickable="true" android:focusable="true" - android:foreground="?rectSelector" - android:gravity="center_vertical" android:minHeight="64dp" android:orientation="horizontal" tools:ignore="MissingPrefix"> @@ -32,8 +30,8 @@ android:layout_width="wrap_content" android:layout_height="match_parent" android:layout_weight="0" - android:paddingEnd="0dp" - android:paddingStart="16dp"> + android:paddingStart="16dp" + android:paddingEnd="0dp"> + android:paddingStart="16dp" + android:paddingEnd="16dp"> - + android:focusable="true"> diff --git a/app/src/main/res/layout/preference_dialog_library_categories_listitem.xml b/app/src/main/res/layout/preference_dialog_library_categories_listitem.xml index 41673f6d2..6952d8baf 100644 --- a/app/src/main/res/layout/preference_dialog_library_categories_listitem.xml +++ b/app/src/main/res/layout/preference_dialog_library_categories_listitem.xml @@ -17,9 +17,9 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" + android:background="?attr/rectSelector" android:descendantFocusability="blocksDescendants" android:focusable="true" - android:foreground="?rectSelector" android:orientation="horizontal" android:paddingStart="16dp" android:paddingEnd="0dp" diff --git a/app/src/main/res/values-night-v27/styles.xml b/app/src/main/res/values-night-v27/styles.xml index 4713ec658..16bbd391e 100644 --- a/app/src/main/res/values-night-v27/styles.xml +++ b/app/src/main/res/values-night-v27/styles.xml @@ -1,5 +1,4 @@ - - @color/darkColorSurface +