Fix search slow, last added slow

app/src/main/java/code/name/monkey/retromusic/activities/MainActivity.kt

@@ -129,7 +129,6 @@ class MainActivity : AbsSlidingMusicPanelActivity(), SharedPreferences.OnSharedP
         val uri = intent.data
         val mimeType = intent.type
         var handled = false
-        println("uri -> $uri")
         if (intent.action != null && intent.action == MediaStore.INTENT_ACTION_MEDIA_PLAY_FROM_SEARCH) {
             val songs = SearchQueryHelper.getSongs(this, intent.extras!!)
             if (MusicPlayerRemote.shuffleMode == MusicService.SHUFFLE_MODE_SHUFFLE) {

app/src/main/java/code/name/monkey/retromusic/activities/PlaylistDetailActivity.kt

@@ -25,6 +25,7 @@ import code.name.monkey.retromusic.model.Playlist
 import code.name.monkey.retromusic.model.Song
 import code.name.monkey.retromusic.mvp.presenter.PlaylistSongsPresenter
 import code.name.monkey.retromusic.mvp.presenter.PlaylistSongsView
+import code.name.monkey.retromusic.util.DensityUtil
 import code.name.monkey.retromusic.util.PlaylistsUtil
 import code.name.monkey.retromusic.util.RetroColorUtil
 import code.name.monkey.retromusic.util.ViewUtil
@@ -50,6 +51,9 @@ class PlaylistDetailActivity : AbsSlidingMusicPanelActivity(), CabHolder, Playli
     override fun onCreate(savedInstanceState: Bundle?) {
         setDrawUnderStatusBar()
         super.onCreate(savedInstanceState)
+        App.musicComponent.inject(this)
+
+        playlistSongsPresenter.attachView(this)
 
         setStatusbarColor(Color.TRANSPARENT)
         setNavigationbarColorAuto()
@@ -65,10 +69,6 @@ class PlaylistDetailActivity : AbsSlidingMusicPanelActivity(), CabHolder, Playli
             finish()
         }
 
-        App.musicComponent.inject(this)
-
-        playlistSongsPresenter.attachView(this)
-
         setUpToolBar()
         setUpRecyclerView()
     }
@@ -160,14 +160,12 @@ class PlaylistDetailActivity : AbsSlidingMusicPanelActivity(), CabHolder, Playli
 
     override fun onMediaStoreChanged() {
         super.onMediaStoreChanged()
-
         if (playlist !is AbsCustomPlaylist) {
             // Playlist deleted
             if (!PlaylistsUtil.doesPlaylistExist(this, playlist.id)) {
                 finish()
                 return
             }
-
             // Playlist renamed
             val playlistName = PlaylistsUtil.getNameForPlaylist(this, playlist.id.toLong())
             if (playlistName != playlist.name) {
@@ -182,8 +180,13 @@ class PlaylistDetailActivity : AbsSlidingMusicPanelActivity(), CabHolder, Playli
         supportActionBar!!.title = title
     }
 
-    private fun checkIsEmpty() {
+    private fun checkForPadding() {
+        val height = DensityUtil.dip2px(this, 52f)
+        recyclerView.setPadding(0, 0, 0, (height ))
+    }
 
+    private fun checkIsEmpty() {
+        checkForPadding()
         empty.visibility = if (adapter.itemCount == 0) View.VISIBLE else View.GONE
         emptyText.visibility = if (adapter.itemCount == 0) View.VISIBLE else View.GONE
     }

app/src/main/java/code/name/monkey/retromusic/activities/SearchActivity.kt

@@ -1,10 +1,8 @@
 package code.name.monkey.retromusic.activities
 
 import android.app.Activity
-import android.app.SearchManager
 import android.app.Service
 import android.content.ActivityNotFoundException
-import android.content.Context
 import android.content.Intent
 import android.content.res.ColorStateList
 import android.os.Bundle
@@ -77,6 +75,10 @@ class SearchActivity : AbsMusicServiceActivity(), OnQueryTextListener, TextWatch
             keyboardPopup.setTextColor(this)
             keyboardPopup.iconTint = this
         }
+        if (savedInstanceState != null) {
+            query = savedInstanceState.getString(QUERY);
+        }
+
     }
 
     private fun setupRecyclerView() {
@@ -104,15 +106,9 @@ class SearchActivity : AbsMusicServiceActivity(), OnQueryTextListener, TextWatch
     }
 
     private fun setupSearchView() {
-        getSystemService(Context.SEARCH_SERVICE) as SearchManager
         searchView.addTextChangedListener(this)
     }
 
-    override fun onResume() {
-        super.onResume()
-        searchPresenter.search(query)
-    }
-
     override fun onDestroy() {
         super.onDestroy()
         searchPresenter.detachView()
@@ -123,11 +119,6 @@ class SearchActivity : AbsMusicServiceActivity(), OnQueryTextListener, TextWatch
         outState.putString(QUERY, query)
     }
 
-    override fun onRestoreInstanceState(savedInstanceState: Bundle) {
-        super.onRestoreInstanceState(savedInstanceState)
-        searchPresenter.search(savedInstanceState.getString(QUERY, ""))
-    }
-
     private fun setUpToolBar() {
         title = null
         appBarLayout.setBackgroundColor(ATHUtil.resolveColor(this, R.attr.colorPrimary))
@@ -135,14 +126,14 @@ class SearchActivity : AbsMusicServiceActivity(), OnQueryTextListener, TextWatch
 
 
     private fun search(query: String) {
-        this.query = query.trim { it <= ' ' }
+        this.query = query
         voiceSearch.visibility = if (query.isNotEmpty()) View.GONE else View.VISIBLE
         searchPresenter.search(query)
     }
 
     override fun onMediaStoreChanged() {
         super.onMediaStoreChanged()
-        searchPresenter.search(query!!)
+        query?.let { search(it) }
     }
 
     override fun onQueryTextSubmit(query: String): Boolean {