From 5c7fb03da79abd9dc691675f4b83a33fe770f091 Mon Sep 17 00:00:00 2001
From: James Westman <james@jwestman.net>
Date: Wed, 7 May 2025 17:08:26 -0500
Subject: [PATCH] Fix incorrect error with Adw.AlertDialog responses

---
 blueprintcompiler/language/contexts.py | 10 ++++++----
 tests/samples/issue_195.blp            | 11 +++++++++++
 tests/samples/issue_195.ui             | 16 ++++++++++++++++
 3 files changed, 33 insertions(+), 4 deletions(-)
 create mode 100644 tests/samples/issue_195.blp
 create mode 100644 tests/samples/issue_195.ui

diff --git a/blueprintcompiler/language/contexts.py b/blueprintcompiler/language/contexts.py
index 6e26048..9376211 100644
--- a/blueprintcompiler/language/contexts.py
+++ b/blueprintcompiler/language/contexts.py
@@ -60,19 +60,21 @@ class ScopeCtx:
 
         passed = {}
         for obj in self._iter_recursive(self.node):
-            if obj.tokens["id"] is None:
+            from .gtk_menu import Menu
+
+            if not (isinstance(obj, Object) or isinstance(obj, Menu)) or obj.id is None:
                 continue
 
-            if obj.tokens["id"] in passed:
+            if obj.id in passed:
                 token = obj.group.tokens["id"]
                 if not isinstance(obj, Template) and not isinstance(
                     obj, ExtListItemFactory
                 ):
                     raise CompileError(
-                        f"Duplicate object ID '{obj.tokens['id']}'",
+                        f"Duplicate object ID '{obj.id}'",
                         token.range,
                     )
-            passed[obj.tokens["id"]] = obj
+            passed[obj.id] = obj
 
     def _iter_recursive(self, node: AstNode):
         yield node
diff --git a/tests/samples/issue_195.blp b/tests/samples/issue_195.blp
new file mode 100644
index 0000000..50b5b95
--- /dev/null
+++ b/tests/samples/issue_195.blp
@@ -0,0 +1,11 @@
+using Gtk 4.0;
+using Adw 1;
+
+Adw.AlertDialog dialog1 {
+  responses [
+    ok: "Ok",
+    cancel: "Cancel",
+  ]
+}
+
+Button cancel {}
diff --git a/tests/samples/issue_195.ui b/tests/samples/issue_195.ui
new file mode 100644
index 0000000..b57a379
--- /dev/null
+++ b/tests/samples/issue_195.ui
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+DO NOT EDIT!
+This file was @generated by blueprint-compiler. Instead, edit the
+corresponding .blp file and regenerate this file with blueprint-compiler.
+-->
+<interface>
+  <requires lib="gtk" version="4.0"/>
+  <object class="AdwAlertDialog" id="dialog1">
+    <responses>
+      <response id="ok">Ok</response>
+      <response id="cancel">Cancel</response>
+    </responses>
+  </object>
+  <object class="GtkButton" id="cancel"></object>
+</interface>
\ No newline at end of file