From f48b840cfa478d6bfeb6e16f24fd5b650c70e4f2 Mon Sep 17 00:00:00 2001
From: kotontrion <kotontrion@tutanota.de>
Date: Wed, 20 Nov 2024 10:41:56 +0100
Subject: [PATCH 1/4] compile: fix flag values

gtk builder does not support combining interger values with | in flags
properties, so the short names are used instead.
---
 blueprintcompiler/language/values.py | 2 +-
 tests/samples/flags.ui               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/blueprintcompiler/language/values.py b/blueprintcompiler/language/values.py
index 63cf4fc..e060b65 100644
--- a/blueprintcompiler/language/values.py
+++ b/blueprintcompiler/language/values.py
@@ -216,7 +216,7 @@ class Flag(AstNode):
         if not isinstance(type, Enumeration):
             return None
         elif member := type.members.get(self.name):
-            return member.value
+            return member.name
         else:
             return None
 
diff --git a/tests/samples/flags.ui b/tests/samples/flags.ui
index 2f0a26e..d13c424 100644
--- a/tests/samples/flags.ui
+++ b/tests/samples/flags.ui
@@ -7,7 +7,7 @@ corresponding .blp file and regenerate this file with blueprint-compiler.
 <interface>
   <requires lib="gtk" version="4.0"/>
   <object class="GApplication">
-    <property name="flags">1|4</property>
+    <property name="flags">is_service|handles_open</property>
   </object>
   <object class="GtkEventControllerScroll">
     <property name="flags">1</property>

From 2ae41020abfb04649e9791f57c84fc708d428283 Mon Sep 17 00:00:00 2001
From: kotontrion <kotontrion@tutanota.de>
Date: Thu, 21 Nov 2024 09:28:40 +0100
Subject: [PATCH 2/4] Fix flag return value type

---
 blueprintcompiler/language/values.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/blueprintcompiler/language/values.py b/blueprintcompiler/language/values.py
index e060b65..4cd600d 100644
--- a/blueprintcompiler/language/values.py
+++ b/blueprintcompiler/language/values.py
@@ -211,7 +211,7 @@ class Flag(AstNode):
         return self.tokens["value"]
 
     @property
-    def value(self) -> T.Optional[int]:
+    def value(self) -> T.Optional[str]:
         type = self.context[ValueTypeCtx].value_type
         if not isinstance(type, Enumeration):
             return None

From e07da3c33946e7ab4afed9c564a9e7ae0b3fbbb8 Mon Sep 17 00:00:00 2001
From: kotontrion <kotontrion@tutanota.de>
Date: Tue, 26 Nov 2024 10:52:37 +0100
Subject: [PATCH 3/4] flags: use nick instead of name

---
 blueprintcompiler/language/values.py | 2 +-
 tests/samples/flags.ui               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/blueprintcompiler/language/values.py b/blueprintcompiler/language/values.py
index 4cd600d..96787ee 100644
--- a/blueprintcompiler/language/values.py
+++ b/blueprintcompiler/language/values.py
@@ -216,7 +216,7 @@ class Flag(AstNode):
         if not isinstance(type, Enumeration):
             return None
         elif member := type.members.get(self.name):
-            return member.name
+            return member.nick
         else:
             return None
 
diff --git a/tests/samples/flags.ui b/tests/samples/flags.ui
index d13c424..44eb2c4 100644
--- a/tests/samples/flags.ui
+++ b/tests/samples/flags.ui
@@ -7,7 +7,7 @@ corresponding .blp file and regenerate this file with blueprint-compiler.
 <interface>
   <requires lib="gtk" version="4.0"/>
   <object class="GApplication">
-    <property name="flags">is_service|handles_open</property>
+    <property name="flags">is-service|handles-open</property>
   </object>
   <object class="GtkEventControllerScroll">
     <property name="flags">1</property>

From aa13c8f5af137bbedd1781d903e923d45d7c41fb Mon Sep 17 00:00:00 2001
From: James Westman <james@jwestman.net>
Date: Sun, 5 Jan 2025 14:27:59 -0600
Subject: [PATCH 4/4] Warn about single-quoted translated strings

gettext only recognizes double quoted strings
---
 blueprintcompiler/language/values.py             | 13 +++++++++++++
 docs/translations.rst                            |  2 ++
 tests/sample_errors/single_quoted_translated.blp |  5 +++++
 tests/sample_errors/single_quoted_translated.err |  1 +
 4 files changed, 21 insertions(+)
 create mode 100644 tests/sample_errors/single_quoted_translated.blp
 create mode 100644 tests/sample_errors/single_quoted_translated.err

diff --git a/blueprintcompiler/language/values.py b/blueprintcompiler/language/values.py
index 5556d99..cb80975 100644
--- a/blueprintcompiler/language/values.py
+++ b/blueprintcompiler/language/values.py
@@ -58,6 +58,19 @@ class Translated(AstNode):
                 f"Cannot convert translated string to {expected_type.full_name}"
             )
 
+    @validate("context")
+    def context_double_quoted(self):
+        if self.translate_context is None:
+            return
+
+        if not str(self.group.tokens["context"]).startswith('"'):
+            raise CompileWarning("gettext may not recognize single-quoted strings")
+
+    @validate("string")
+    def string_double_quoted(self):
+        if not str(self.group.tokens["string"]).startswith('"'):
+            raise CompileWarning("gettext may not recognize single-quoted strings")
+
     @docs()
     def ref_docs(self):
         return get_docs_section("Syntax Translated")
diff --git a/docs/translations.rst b/docs/translations.rst
index 7ebf929..7af2099 100644
--- a/docs/translations.rst
+++ b/docs/translations.rst
@@ -24,6 +24,8 @@ If you're using Meson's `i18n module <https://mesonbuild.com/i18n-module.html#i1
 
    i18n.gettext('package name', preset: 'glib')
 
+You must use double quotes for the translated strings in order for gettext to recognize them. Newer versions of blueprint will warn you if you use single quotes.
+
 Contexts
 --------
 
diff --git a/tests/sample_errors/single_quoted_translated.blp b/tests/sample_errors/single_quoted_translated.blp
new file mode 100644
index 0000000..718fd49
--- /dev/null
+++ b/tests/sample_errors/single_quoted_translated.blp
@@ -0,0 +1,5 @@
+using Gtk 4.0;
+
+Label {
+  label: _('Hello, World!');
+}
\ No newline at end of file
diff --git a/tests/sample_errors/single_quoted_translated.err b/tests/sample_errors/single_quoted_translated.err
new file mode 100644
index 0000000..c725580
--- /dev/null
+++ b/tests/sample_errors/single_quoted_translated.err
@@ -0,0 +1 @@
+4,12,15,gettext may not recognize single-quoted strings
\ No newline at end of file