Siklos/libgit2dart
1
0
Fork 0
mirror of https://github.com/SkinnyMind/libgit2dart.git synced 2025-05-05 04:39:07 -04:00
Code Issues Projects Releases Wiki Activity

refactor(reflog): use Signature class instead of Map

Browse source
This commit is contained in:
Aleksey Kulikov 2021-08-24 19:13:21 +03:00
parent dc5f510aa5
commit 0509895b72
4 changed files with 15 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lib/src/bindings/reflog.dart
View file

@ -43,14 +43,9 @@ String entryMessage(Pointer<git_reflog_entry> entry) {
return result.cast<Utf8>().toDartString(); return result.cast<Utf8>().toDartString();
} }
/// Get the committer of this entry (name, email, seconds from epoch). /// Get the committer of this entry.
Map<String, Object> entryCommiter(Pointer<git_reflog_entry> entry) { Pointer<git_signature> entryCommiter(Pointer<git_reflog_entry> entry) {
final result = libgit2.git_reflog_entry_committer(entry); return libgit2.git_reflog_entry_committer(entry);
var committer = <String, Object>{};
committer['name'] = result.ref.name.cast<Utf8>().toDartString();
committer['email'] = result.ref.email.cast<Utf8>().toDartString();
committer['when'] = result.ref.when.time;
return committer;
} }
/// Free the reflog. /// Free the reflog.

5
lib/src/reflog.dart
View file

@ -2,6 +2,7 @@ import 'dart:ffi';
import 'bindings/libgit2_bindings.dart'; import 'bindings/libgit2_bindings.dart';
import 'bindings/reflog.dart' as bindings; import 'bindings/reflog.dart' as bindings;
import 'reference.dart'; import 'reference.dart';
import 'signature.dart';
import 'util.dart'; import 'util.dart';
class RefLog { class RefLog {
@ -58,6 +59,6 @@ class RefLogEntry {
/// Returns the log message. /// Returns the log message.
String get message => bindings.entryMessage(_entryPointer); String get message => bindings.entryMessage(_entryPointer);
/// Returns the committer of this entry (name, email, seconds from epoch). /// Returns the committer of this entry.
Map<String, Object> get committer => bindings.entryCommiter(_entryPointer); Signature get committer => Signature(bindings.entryCommiter(_entryPointer));
} }

12
test/reference_test.dart
View file

@ -165,8 +165,8 @@ void main() {
final reflogEntry = reflog.entryAt(0); final reflogEntry = reflog.entryAt(0);
expect(reflogEntry.message, 'log message'); expect(reflogEntry.message, 'log message');
expect(reflogEntry.committer['name'], 'name'); expect(reflogEntry.committer.name, 'name');
expect(reflogEntry.committer['email'], 'email'); expect(reflogEntry.committer.email, 'email');
reflog.free(); reflog.free();
ref.free(); ref.free();
@ -300,8 +300,8 @@ void main() {
final reflogEntry = reflog.entryAt(0); final reflogEntry = reflog.entryAt(0);
expect(reflogEntry.message, 'log message'); expect(reflogEntry.message, 'log message');
expect(reflogEntry.committer['name'], 'name'); expect(reflogEntry.committer.name, 'name');
expect(reflogEntry.committer['email'], 'email'); expect(reflogEntry.committer.email, 'email');
reflog.free(); reflog.free();
ref.free(); ref.free();
@ -380,8 +380,8 @@ void main() {
expect(ref.target.sha, '5aecfa0fb97eadaac050ccb99f03c3fb65460ad4'); expect(ref.target.sha, '5aecfa0fb97eadaac050ccb99f03c3fb65460ad4');
final reflog = ref.log; final reflog = ref.log;
expect(reflog.list().first.message, 'log message'); expect(reflog.list().first.message, 'log message');
expect(reflog.list().first.committer['name'], 'name'); expect(reflog.list().first.committer.name, 'name');
expect(reflog.list().first.committer['email'], 'email'); expect(reflog.list().first.committer.email, 'email');
reflog.free(); reflog.free();
ref.free(); ref.free();

6
test/reflog_test.dart
View file

@ -49,9 +49,9 @@ void main() {
test('returns the committer of the entry', () { test('returns the committer of the entry', () {
final entry = reflog.entryAt(0); final entry = reflog.entryAt(0);
expect(entry.committer['name'], 'Aleksey Kulikov'); expect(entry.committer.name, 'Aleksey Kulikov');
expect(entry.committer['email'], 'skinny.mind@gmail.com'); expect(entry.committer.email, 'skinny.mind@gmail.com');
expect(entry.committer['when'], 1626091184); expect(entry.committer.time, 1626091184);
}); });
}); });
} }