From 3fc92cd9379f2ba2208646e61bcd7e07adc9b695 Mon Sep 17 00:00:00 2001 From: Aleksey Kulikov Date: Wed, 4 May 2022 16:47:25 +0300 Subject: [PATCH] refactor: move named arguments to front of tests Use Dart's new feature "Named args everywhere" --- test/credentials_test.dart | 4 ++-- test/remote_test.dart | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/credentials_test.dart b/test/credentials_test.dart index 28713cf..cdfaa1c 100644 --- a/test/credentials_test.dart +++ b/test/credentials_test.dart @@ -84,6 +84,7 @@ void main() { }); test( + testOn: '!linux', 'clones repository with provided keypair', () { final cloneDir = Directory.systemTemp.createTempSync('clone'); @@ -107,7 +108,6 @@ void main() { cloneDir.deleteSync(recursive: true); } }, - testOn: '!linux', ); test('throws when no credentials is provided', () { @@ -190,6 +190,7 @@ void main() { }); test( + testOn: '!linux', 'clones repository with provided keypair from memory', () { final cloneDir = Directory.systemTemp.createTempSync('clone'); @@ -217,7 +218,6 @@ void main() { cloneDir.deleteSync(recursive: true); } }, - testOn: '!linux', ); test('throws when provided keypair from memory is incorrect', () { diff --git a/test/remote_test.dart b/test/remote_test.dart index 3b0e1de..07e7c34 100644 --- a/test/remote_test.dart +++ b/test/remote_test.dart @@ -282,6 +282,7 @@ void main() { }); test( + tags: 'remote_fetch', 'fetches data', () { Remote.setUrl( @@ -309,10 +310,10 @@ void main() { expect(stats.receivedBytes, 0); expect(stats.toString(), contains('TransferProgress{')); }, - tags: 'remote_fetch', ); test( + tags: 'remote_fetch', 'fetches data with proxy set to auto', () { Remote.setUrl( @@ -341,10 +342,10 @@ void main() { expect(stats.receivedBytes, 0); expect(stats.toString(), contains('TransferProgress{')); }, - tags: 'remote_fetch', ); test( + tags: 'remote_fetch', 'uses specified proxy for fetch', () { Remote.setUrl( @@ -367,7 +368,6 @@ void main() { throwsA(isA()), ); }, - tags: 'remote_fetch', ); test('throws when trying to fetch data with invalid url', () { @@ -381,6 +381,7 @@ void main() { }); test( + tags: 'remote_fetch', 'fetches data with provided transfer progress callback', () { Remote.setUrl( @@ -403,10 +404,10 @@ void main() { expect(stats.indexedDeltas == callbackStats?.indexedDeltas, true); expect(stats.receivedBytes == callbackStats?.receivedBytes, true); }, - tags: 'remote_fetch', ); test( + tags: 'remote_fetch', 'fetches data with provided sideband progress callback', () { const sidebandMessage = """ @@ -427,10 +428,10 @@ Total 69 (delta 0), reused 1 (delta 0), pack-reused 68 remote.fetch(callbacks: Callbacks(sidebandProgress: sideband)); expect(sidebandOutput.toString(), sidebandMessage); }, - tags: 'remote_fetch', ); test( + tags: 'remote_fetch', 'fetches data with provided update tips callback', () { Remote.setUrl( @@ -469,7 +470,6 @@ Total 69 (delta 0), reused 1 (delta 0), pack-reused 68 remote.fetch(callbacks: Callbacks(updateTips: updateTips)); expect(updateTipsOutput, tipsExpected); }, - tags: 'remote_fetch', ); test('pushes with update reference callback', () {