refactor!: use named arguments if there is more than one

This commit is contained in:
Aleksey Kulikov 2021-09-30 18:04:36 +03:00
parent ec80ad3dd4
commit 5f7fdf4bd3
66 changed files with 1920 additions and 1136 deletions

View file

@ -15,7 +15,7 @@ void main() {
setUp(() async {
tmpDir = await setupRepo(Directory('test/assets/testrepo/'));
repo = Repository.open(tmpDir.path);
blob = Blob.lookup(repo, blobSHA);
blob = Blob.lookup(repo: repo, sha: blobSHA);
});
tearDown(() async {
@ -37,8 +37,8 @@ void main() {
});
test('successfully creates new blob', () {
final oid = Blob.create(repo, newBlobContent);
final newBlob = Blob.lookup(repo, oid.sha);
final oid = Blob.create(repo: repo, content: newBlobContent);
final newBlob = Blob.lookup(repo: repo, sha: oid.sha);
expect(newBlob.id.sha, '18fdaeef018e57a92bcad2d4a35b577f34089af6');
expect(newBlob.isBinary, false);
@ -50,8 +50,11 @@ void main() {
test('successfully creates new blob from file at provided relative path',
() {
final oid = Blob.createFromWorkdir(repo, 'feature_file');
final newBlob = Blob.lookup(repo, oid.sha);
final oid = Blob.createFromWorkdir(
repo: repo,
relativePath: 'feature_file',
);
final newBlob = Blob.lookup(repo: repo, sha: oid.sha);
expect(newBlob.id.sha, blobSHA);
expect(newBlob.isBinary, false);
@ -63,7 +66,10 @@ void main() {
test('throws when creating new blob from invalid path', () {
expect(
() => Blob.createFromWorkdir(repo, 'invalid/path.txt'),
() => Blob.createFromWorkdir(
repo: repo,
relativePath: 'invalid/path.txt',
),
throwsA(isA<LibGit2Error>()),
);
});
@ -74,7 +80,10 @@ void main() {
final outsideFile =
File('${Directory.current.absolute.path}/test/blob_test.dart');
expect(
() => Blob.createFromWorkdir(repo, outsideFile.path),
() => Blob.createFromWorkdir(
repo: repo,
relativePath: outsideFile.path,
),
throwsA(isA<LibGit2Error>()),
);
});
@ -82,8 +91,8 @@ void main() {
test('successfully creates new blob from file at provided path', () {
final outsideFile =
File('${Directory.current.absolute.path}/test/blob_test.dart');
final oid = Blob.createFromDisk(repo, outsideFile.path);
final newBlob = Blob.lookup(repo, oid.sha);
final oid = Blob.createFromDisk(repo: repo, path: outsideFile.path);
final newBlob = Blob.lookup(repo: repo, sha: oid.sha);
expect(newBlob, isA<Blob>());
expect(newBlob.isBinary, false);

View file

@ -89,7 +89,7 @@ void main() {
group('get multivar values', () {
test('returns list of values', () {
expect(
config.multivar('core.gitproxy'),
config.multivar(variable: 'core.gitproxy'),
[
'proxy-command for kernel.org',
'default-proxy',
@ -99,27 +99,38 @@ void main() {
test('returns list of values for provided regexp', () {
expect(
config.multivar('core.gitproxy', regexp: 'for kernel.org\$'),
config.multivar(
variable: 'core.gitproxy',
regexp: 'for kernel.org\$',
),
['proxy-command for kernel.org'],
);
});
test('returns empty list if multivar not found', () {
expect(config.multivar('not.there'), []);
expect(config.multivar(variable: 'not.there'), []);
});
});
group('setMultivarValue()', () {
test('sets value of multivar', () {
config.setMultivar('core.gitproxy', 'default', 'updated');
final multivarValues = config.multivar('core.gitproxy');
config.setMultivar(
variable: 'core.gitproxy',
regexp: 'default',
value: 'updated',
);
final multivarValues = config.multivar(variable: 'core.gitproxy');
expect(multivarValues, isNot(contains('default-proxy')));
expect(multivarValues, contains('updated'));
});
test('sets value for all multivar values when regexp is empty', () {
config.setMultivar('core.gitproxy', '', 'updated');
final multivarValues = config.multivar('core.gitproxy');
config.setMultivar(
variable: 'core.gitproxy',
regexp: '',
value: 'updated',
);
final multivarValues = config.multivar(variable: 'core.gitproxy');
expect(multivarValues, isNot(contains('default-proxy')));
expect(multivarValues, isNot(contains('proxy-command for kernel.org')));
expect(multivarValues, contains('updated'));
@ -130,14 +141,23 @@ void main() {
group('deleteMultivar()', () {
test('successfully deletes value of a multivar', () {
expect(
config.multivar('core.gitproxy', regexp: 'for kernel.org\$'),
config.multivar(
variable: 'core.gitproxy',
regexp: 'for kernel.org\$',
),
['proxy-command for kernel.org'],
);
config.deleteMultivar('core.gitproxy', 'for kernel.org\$');
config.deleteMultivar(
variable: 'core.gitproxy',
regexp: 'for kernel.org\$',
);
expect(
config.multivar('core.gitproxy', regexp: 'for kernel.org\$'),
config.multivar(
variable: 'core.gitproxy',
regexp: 'for kernel.org\$',
),
[],
);
});
@ -145,16 +165,16 @@ void main() {
test('successfully deletes all values of a multivar when regexp is empty',
() {
expect(
config.multivar('core.gitproxy'),
config.multivar(variable: 'core.gitproxy'),
[
'proxy-command for kernel.org',
'default-proxy',
],
);
config.deleteMultivar('core.gitproxy', '');
config.deleteMultivar(variable: 'core.gitproxy', regexp: '');
expect(config.multivar('core.gitproxy'), []);
expect(config.multivar(variable: 'core.gitproxy'), []);
});
});
});

View file

@ -194,7 +194,10 @@ index e69de29..c217c63 100644
final diff = Diff.parse(patchText);
final file = File('${tmpDir.path}/subdir/modified_file');
repo.reset('a763aa560953e7cfb87ccbc2f536d665aa4dff22', GitReset.hard);
repo.reset(
target: 'a763aa560953e7cfb87ccbc2f536d665aa4dff22',
resetType: GitReset.hard,
);
expect(file.readAsStringSync(), '');
expect(repo.applies(diff), true);
@ -206,7 +209,7 @@ index e69de29..c217c63 100644
test('successfully creates patch from entry index in diff', () {
final diff = Diff.parse(patchText);
final patch = Patch.fromDiff(diff, 0);
final patch = Patch.fromDiff(diff: diff, index: 0);
expect(diff.length, 1);
expect(patch.text, patchText);
@ -298,7 +301,7 @@ index e69de29..c217c63 100644
expect(stats.insertions, 4);
expect(stats.deletions, 2);
expect(stats.filesChanged, 8);
expect(stats.print({GitDiffStats.full}, 80), statsPrint);
expect(stats.print(format: {GitDiffStats.full}, width: 80), statsPrint);
stats.free();
diff.free();
@ -315,7 +318,7 @@ index e69de29..c217c63 100644
test('returns hunks in a patch', () {
final diff = Diff.parse(patchText);
final patch = Patch.fromDiff(diff, 0);
final patch = Patch.fromDiff(diff: diff, index: 0);
final hunk = patch.hunks[0];
expect(patch.hunks.length, 1);
@ -332,7 +335,7 @@ index e69de29..c217c63 100644
test('returns lines in a hunk', () {
final diff = Diff.parse(patchText);
final patch = Patch.fromDiff(diff, 0);
final patch = Patch.fromDiff(diff: diff, index: 0);
final hunk = patch.hunks[0];
final line = hunk.lines[0];

View file

@ -24,7 +24,7 @@ void main() {
final commit =
repo['c68ff54aabf660fcdd9a2838d401583fe31249e3'] as Commit;
final result = repo.mergeAnalysis(commit.id);
final result = repo.mergeAnalysis(theirHead: commit.id);
expect(result[0], {GitMergeAnalysis.upToDate});
expect(result[1], {GitMergePreference.none});
expect(repo.status, isEmpty);
@ -36,7 +36,10 @@ void main() {
final commit =
repo['c68ff54aabf660fcdd9a2838d401583fe31249e3'] as Commit;
final result = repo.mergeAnalysis(commit.id, 'refs/tags/v0.1');
final result = repo.mergeAnalysis(
theirHead: commit.id,
ourRef: 'refs/tags/v0.1',
);
expect(result[0], {GitMergeAnalysis.upToDate});
expect(repo.status, isEmpty);
@ -53,7 +56,10 @@ void main() {
target: ffCommit,
);
final result = repo.mergeAnalysis(theirHead.id, ffBranch.name);
final result = repo.mergeAnalysis(
theirHead: theirHead.id,
ourRef: ffBranch.name,
);
expect(
result[0],
{GitMergeAnalysis.fastForward, GitMergeAnalysis.normal},
@ -69,7 +75,7 @@ void main() {
final commit =
repo['5aecfa0fb97eadaac050ccb99f03c3fb65460ad4'] as Commit;
final result = repo.mergeAnalysis(commit.id);
final result = repo.mergeAnalysis(theirHead: commit.id);
expect(result[0], {GitMergeAnalysis.normal});
expect(repo.status, isEmpty);
@ -81,7 +87,7 @@ void main() {
final conflictBranch = repo.branches['conflict-branch'];
final index = repo.index;
final result = repo.mergeAnalysis(conflictBranch.target);
final result = repo.mergeAnalysis(theirHead: conflictBranch.target);
expect(result[0], {GitMergeAnalysis.normal});
repo.merge(conflictBranch.target);
@ -212,7 +218,7 @@ void main() {
final ourCommit =
repo['14905459d775f3f56a39ebc2ff081163f7da3529'] as Commit;
final baseCommit =
repo[repo.mergeBase(ourCommit.id.sha, theirCommit.id.sha).sha]
repo[repo.mergeBase(a: ourCommit.id.sha, b: theirCommit.id.sha).sha]
as Commit;
final theirTree = theirCommit.tree;
final ourTree = ourCommit.tree;
@ -250,7 +256,7 @@ void main() {
final ourCommit =
repo['14905459d775f3f56a39ebc2ff081163f7da3529'] as Commit;
final baseCommit =
repo[repo.mergeBase(ourCommit.id.sha, theirCommit.id.sha).sha]
repo[repo.mergeBase(a: ourCommit.id.sha, b: theirCommit.id.sha).sha]
as Commit;
final theirTree = theirCommit.tree;
final ourTree = ourCommit.tree;

View file

@ -27,7 +27,10 @@ void main() {
});
test('finds object by short oid', () {
final oid = Oid.fromSHA(repo, lastCommit.substring(0, 5));
final oid = Oid.fromSHA(
repo: repo,
sha: lastCommit.substring(0, 5),
);
expect(oid.sha, lastCommit);
});
});

View file

@ -24,13 +24,13 @@ void main() {
group('Oid', () {
group('fromSHA()', () {
test('initializes successfully', () {
final oid = Oid.fromSHA(repo, sha);
final oid = Oid.fromSHA(repo: repo, sha: sha);
expect(oid, isA<Oid>());
expect(oid.sha, sha);
});
test('initializes successfully from short hex string', () {
final oid = Oid.fromSHA(repo, sha.substring(0, 5));
final oid = Oid.fromSHA(repo: repo, sha: sha.substring(0, 5));
expect(oid, isA<Oid>());
expect(oid.sha, sha);
@ -39,7 +39,7 @@ void main() {
group('fromRaw()', () {
test('initializes successfully', () {
final sourceOid = Oid.fromSHA(repo, sha);
final sourceOid = Oid.fromSHA(repo: repo, sha: sha);
final oid = Oid.fromRaw(sourceOid.pointer.ref);
expect(oid, isA<Oid>());
expect(oid.sha, sha);
@ -47,27 +47,27 @@ void main() {
});
test('returns sha hex string', () {
final oid = Oid.fromSHA(repo, sha);
final oid = Oid.fromSHA(repo: repo, sha: sha);
expect(oid.sha, equals(sha));
});
group('compare', () {
test('< and <=', () {
final oid1 = Oid.fromSHA(repo, sha);
final oid2 = Oid.fromSHA(repo, biggerSha);
final oid1 = Oid.fromSHA(repo: repo, sha: sha);
final oid2 = Oid.fromSHA(repo: repo, sha: biggerSha);
expect(oid1 < oid2, true);
expect(oid1 <= oid2, true);
});
test('==', () {
final oid1 = Oid.fromSHA(repo, sha);
final oid2 = Oid.fromSHA(repo, sha);
final oid1 = Oid.fromSHA(repo: repo, sha: sha);
final oid2 = Oid.fromSHA(repo: repo, sha: sha);
expect(oid1 == oid2, true);
});
test('> and >=', () {
final oid1 = Oid.fromSHA(repo, sha);
final oid2 = Oid.fromSHA(repo, lesserSha);
final oid1 = Oid.fromSHA(repo: repo, sha: sha);
final oid2 = Oid.fromSHA(repo: repo, sha: lesserSha);
expect(oid1 > oid2, true);
expect(oid1 >= oid2, true);
});

View file

@ -346,7 +346,7 @@ void main() {
group('set target', () {
test('successfully sets with SHA hex', () {
final ref = repo.references['refs/heads/master'];
ref.setTarget(newCommit);
ref.setTarget(target: newCommit);
expect(ref.target.sha, newCommit);
ref.free();
@ -354,7 +354,7 @@ void main() {
test('successfully sets target with short SHA hex', () {
final ref = repo.references['refs/heads/master'];
ref.setTarget(newCommit.substring(0, 5));
ref.setTarget(target: newCommit.substring(0, 5));
expect(ref.target.sha, newCommit);
ref.free();
@ -364,7 +364,7 @@ void main() {
final ref = repo.references['HEAD'];
expect(ref.target.sha, lastCommit);
ref.setTarget('refs/heads/feature');
ref.setTarget(target: 'refs/heads/feature');
expect(ref.target.sha, '5aecfa0fb97eadaac050ccb99f03c3fb65460ad4');
ref.free();
@ -375,7 +375,7 @@ void main() {
expect(ref.target.sha, lastCommit);
repo.setIdentity(name: 'name', email: 'email');
ref.setTarget('refs/heads/feature', 'log message');
ref.setTarget(target: 'refs/heads/feature', logMessage: 'log message');
expect(ref.target.sha, '5aecfa0fb97eadaac050ccb99f03c3fb65460ad4');
final reflog = ref.log;
expect(reflog.first.message, 'log message');
@ -389,7 +389,7 @@ void main() {
test('throws on invalid target', () {
final ref = repo.references['HEAD'];
expect(
() => ref.setTarget('refs/heads/invalid~'),
() => ref.setTarget(target: 'refs/heads/invalid~'),
throwsA(isA<LibGit2Error>()),
);
@ -405,7 +405,7 @@ void main() {
);
expect(ref.name, 'refs/tags/v1');
ref.rename('refs/tags/v2');
ref.rename(newName: 'refs/tags/v2');
expect(ref.name, 'refs/tags/v2');
ref.free();
@ -418,7 +418,7 @@ void main() {
);
expect(
() => ref.rename('refs/tags/invalid~'),
() => ref.rename(newName: 'refs/tags/invalid~'),
throwsA(isA<LibGit2Error>()),
);
@ -437,7 +437,7 @@ void main() {
);
expect(
() => ref1.rename('refs/tags/v2'),
() => ref1.rename(newName: 'refs/tags/v2'),
throwsA(isA<LibGit2Error>()),
);
@ -458,7 +458,7 @@ void main() {
expect(ref2.target.sha, newCommit);
ref1.rename('refs/tags/v2', force: true);
ref1.rename(newName: 'refs/tags/v2', force: true);
expect(ref1.name, 'refs/tags/v2');
ref1.free();

View file

@ -79,7 +79,7 @@ void main() {
test('successfully renames', () {
final remote = repo.remotes[remoteName];
final problems = repo.remotes.rename(remoteName, 'new');
final problems = repo.remotes.rename(remote: remoteName, newName: 'new');
expect(problems, isEmpty);
expect(remote.name, isNot('new'));
@ -91,7 +91,10 @@ void main() {
});
test('throws when renaming with invalid names', () {
expect(() => repo.remotes.rename('', ''), throwsA(isA<LibGit2Error>()));
expect(
() => repo.remotes.rename(remote: '', newName: ''),
throwsA(isA<LibGit2Error>()),
);
});
test('successfully sets url', () {
@ -99,7 +102,7 @@ void main() {
expect(remote.url, remoteUrl);
const newUrl = 'git://new/url.git';
repo.remotes.setUrl(remoteName, newUrl);
repo.remotes.setUrl(remote: remoteName, url: newUrl);
final newRemote = repo.remotes[remoteName];
expect(newRemote.url, newUrl);
@ -110,14 +113,14 @@ void main() {
test('throws when trying to set invalid url name', () {
expect(
() => repo.remotes.setUrl('origin', ''),
() => repo.remotes.setUrl(remote: 'origin', url: ''),
throwsA(isA<LibGit2Error>()),
);
});
test('successfully sets url for pushing', () {
const newUrl = 'git://new/url.git';
repo.remotes.setPushUrl(remoteName, newUrl);
repo.remotes.setPushUrl(remote: remoteName, url: newUrl);
final remote = repo.remotes[remoteName];
expect(remote.pushUrl, newUrl);
@ -127,7 +130,7 @@ void main() {
test('throws when trying to set invalid push url name', () {
expect(
() => repo.remotes.setPushUrl('origin', ''),
() => repo.remotes.setPushUrl(remote: 'origin', url: ''),
throwsA(isA<LibGit2Error>()),
);
});
@ -159,7 +162,10 @@ void main() {
});
test('successfully adds fetch refspec', () {
repo.remotes.addFetch('origin', '+refs/test/*:refs/test/remotes/*');
repo.remotes.addFetch(
remote: 'origin',
refspec: '+refs/test/*:refs/test/remotes/*',
);
final remote = repo.remotes['origin'];
expect(remote.fetchRefspecs.length, 2);
expect(
@ -174,7 +180,10 @@ void main() {
});
test('successfully adds push refspec', () {
repo.remotes.addPush('origin', '+refs/test/*:refs/test/remotes/*');
repo.remotes.addPush(
remote: 'origin',
refspec: '+refs/test/*:refs/test/remotes/*',
);
final remote = repo.remotes['origin'];
expect(remote.pushRefspecs.length, 1);
expect(remote.pushRefspecs, ['+refs/test/*:refs/test/remotes/*']);
@ -184,8 +193,8 @@ void main() {
test('successfully returns remote repo\'s reference list', () {
repo.remotes.setUrl(
'libgit2',
'https://github.com/libgit2/TestGitRepository',
remote: 'libgit2',
url: 'https://github.com/libgit2/TestGitRepository',
);
final remote = repo.remotes['libgit2'];
@ -204,8 +213,8 @@ void main() {
test('successfully fetches data', () {
repo.remotes.setUrl(
'libgit2',
'https://github.com/libgit2/TestGitRepository',
remote: 'libgit2',
url: 'https://github.com/libgit2/TestGitRepository',
);
final remote = repo.remotes['libgit2'];
@ -225,8 +234,8 @@ void main() {
test('successfully fetches data with provided transfer progress callback',
() {
repo.remotes.setUrl(
'libgit2',
'https://github.com/libgit2/TestGitRepository',
remote: 'libgit2',
url: 'https://github.com/libgit2/TestGitRepository',
);
final remote = repo.remotes['libgit2'];
@ -255,8 +264,8 @@ Counting objects: 100% (1/1)\rCounting objects: 100% (1/1), done.
Total 69 (delta 0), reused 1 (delta 0), pack-reused 68
""";
repo.remotes.setUrl(
'libgit2',
'https://github.com/libgit2/TestGitRepository',
remote: 'libgit2',
url: 'https://github.com/libgit2/TestGitRepository',
);
final remote = repo.remotes['libgit2'];
@ -275,8 +284,8 @@ Total 69 (delta 0), reused 1 (delta 0), pack-reused 68
test('successfully fetches data with provided update tips callback', () {
repo.remotes.setUrl(
'libgit2',
'https://github.com/libgit2/TestGitRepository',
remote: 'libgit2',
url: 'https://github.com/libgit2/TestGitRepository',
);
final remote = repo.remotes['libgit2'];
const tipsExpected = [

View file

@ -40,7 +40,7 @@ void main() {
'6cbc22e509d72758ab4c8d9f287ea846b90c448b',
'f17d0d48eae3aa08cecf29128a35e310c97b3521',
];
final commits = repo.log(lastCommit);
final commits = repo.log(sha: lastCommit);
for (var i = 0; i < commits.length; i++) {
expect(commits[i].id.sha, log[i]);
@ -55,11 +55,11 @@ void main() {
test('discovers repository', () async {
final subDir = '${tmpDir.path}/subdir1/subdir2/';
await Directory(subDir).create(recursive: true);
expect(Repository.discover(subDir), repo.path);
expect(Repository.discover(startPath: subDir), repo.path);
});
test('returns empty string when repository not found', () {
expect(Repository.discover(Directory.systemTemp.path), '');
expect(Repository.discover(startPath: Directory.systemTemp.path), '');
});
});
@ -79,7 +79,7 @@ void main() {
final tmpWorkDir = Directory('${Directory.systemTemp.path}/tmp_work_dir');
tmpWorkDir.createSync();
repo.setWorkdir(tmpWorkDir.path);
repo.setWorkdir(path: tmpWorkDir.path);
expect(repo.workdir, '${tmpWorkDir.path}/');
tmpWorkDir.deleteSync();
@ -166,7 +166,7 @@ void main() {
const message = 'init tag\n';
final oid = Tag.create(
repository: repo,
repo: repo,
tagName: tagName,
target: target,
targetType: GitObject.commit,

View file

@ -26,7 +26,7 @@ void main() {
var contents = file.readAsStringSync();
expect(contents, 'Feature edit\n');
repo.reset(sha, GitReset.hard);
repo.reset(target: sha, resetType: GitReset.hard);
contents = file.readAsStringSync();
expect(contents, isEmpty);
});
@ -35,7 +35,7 @@ void main() {
var contents = file.readAsStringSync();
expect(contents, 'Feature edit\n');
repo.reset(sha, GitReset.soft);
repo.reset(target: sha, resetType: GitReset.soft);
contents = file.readAsStringSync();
expect(contents, 'Feature edit\n');
@ -50,7 +50,7 @@ void main() {
var contents = file.readAsStringSync();
expect(contents, 'Feature edit\n');
repo.reset(sha, GitReset.mixed);
repo.reset(target: sha, resetType: GitReset.mixed);
contents = file.readAsStringSync();
expect(contents, 'Feature edit\n');

View file

@ -94,7 +94,7 @@ void main() {
expect(revspec.to?.id.sha, '5aecfa0fb97eadaac050ccb99f03c3fb65460ad4');
expect(revspec.flags, {GitRevSpec.range, GitRevSpec.mergeBase});
expect(
repo.mergeBase(revspec.from.id.sha, revspec.to!.id.sha),
repo.mergeBase(a: revspec.from.id.sha, b: revspec.to!.id.sha),
isA<Oid>(),
);

View file

@ -28,7 +28,7 @@ void main() {
group('RevWalk', () {
test('returns list of commits with default sorting', () {
final walker = RevWalk(repo);
final start = Oid.fromSHA(repo, log.first);
final start = Oid.fromSHA(repo: repo, sha: log.first);
walker.push(start);
final commits = walker.walk();
@ -45,7 +45,7 @@ void main() {
test('returns list of commits with reverse sorting', () {
final walker = RevWalk(repo);
final start = Oid.fromSHA(repo, log.first);
final start = Oid.fromSHA(repo: repo, sha: log.first);
walker.push(start);
walker.sorting({GitSort.reverse});
@ -63,7 +63,7 @@ void main() {
test('successfully changes sorting', () {
final walker = RevWalk(repo);
final start = Oid.fromSHA(repo, log.first);
final start = Oid.fromSHA(repo: repo, sha: log.first);
walker.push(start);
final timeSortedCommits = walker.walk();
@ -89,8 +89,8 @@ void main() {
test('successfully hides commit and its ancestors', () {
final walker = RevWalk(repo);
final start = Oid.fromSHA(repo, log.first);
final oidToHide = Oid.fromSHA(repo, log[2]);
final start = Oid.fromSHA(repo: repo, sha: log.first);
final oidToHide = Oid.fromSHA(repo: repo, sha: log[2]);
walker.push(start);
walker.hide(oidToHide);
@ -106,7 +106,7 @@ void main() {
test('successfully resets walker', () {
final walker = RevWalk(repo);
final start = Oid.fromSHA(repo, log.first);
final start = Oid.fromSHA(repo: repo, sha: log.first);
walker.push(start);
walker.reset();
@ -120,7 +120,7 @@ void main() {
test('simplifies walker by enqueuing only first parent for each commit',
() {
final walker = RevWalk(repo);
final start = Oid.fromSHA(repo, log.first);
final start = Oid.fromSHA(repo: repo, sha: log.first);
walker.push(start);
walker.simplifyFirstParent();

View file

@ -13,7 +13,7 @@ void main() {
setUp(() async {
tmpDir = await setupRepo(Directory('test/assets/testrepo/'));
repo = Repository.open(tmpDir.path);
tag = Tag.lookup(repo, tagSHA);
tag = Tag.lookup(repo: repo, sha: tagSHA);
});
tearDown(() async {
@ -58,7 +58,7 @@ void main() {
const message = 'init tag\n';
final oid = Tag.create(
repository: repo,
repo: repo,
tagName: tagName,
target: target,
targetType: GitObject.commit,
@ -66,7 +66,7 @@ void main() {
message: message,
);
final newTag = Tag.lookup(repo, oid.sha);
final newTag = Tag.lookup(repo: repo, sha: oid.sha);
final tagger = newTag.tagger;
final newTagTarget = newTag.target as Commit;

View file

@ -14,7 +14,7 @@ void main() {
setUp(() async {
tmpDir = await setupRepo(Directory('test/assets/testrepo/'));
repo = Repository.open(tmpDir.path);
tree = Tree.lookup(repo, treeSHA);
tree = Tree.lookup(repo: repo, sha: treeSHA);
});
tearDown(() async {
@ -64,10 +64,14 @@ void main() {
test('successfully creates tree', () {
final fileOid = repo.createBlob('blob content');
final builder = TreeBuilder(repo);
final builder = TreeBuilder(repo: repo);
builder.add('filename', fileOid, GitFilemode.blob);
final newTree = Tree.lookup(repo, builder.write().sha);
builder.add(
filename: 'filename',
oid: fileOid,
filemode: GitFilemode.blob,
);
final newTree = Tree.lookup(repo: repo, sha: builder.write().sha);
final entry = newTree['filename'];
expect(newTree.length, 1);

View file

@ -13,7 +13,7 @@ void main() {
setUp(() async {
tmpDir = await setupRepo(Directory('test/assets/testrepo/'));
repo = Repository.open(tmpDir.path);
tree = Tree.lookup(repo, treeSHA);
tree = Tree.lookup(repo: repo, sha: treeSHA);
});
tearDown(() async {
@ -24,13 +24,13 @@ void main() {
group('TreeBuilder', () {
test('successfully initializes tree builder when no tree is provided', () {
final builder = TreeBuilder(repo);
final builder = TreeBuilder(repo: repo);
expect(builder, isA<TreeBuilder>());
builder.free();
});
test('successfully initializes tree builder with provided tree', () {
final builder = TreeBuilder(repo, tree);
final builder = TreeBuilder(repo: repo, tree: tree);
final oid = builder.write();
expect(builder, isA<TreeBuilder>());
@ -41,7 +41,7 @@ void main() {
});
test('clears all the entries in the builder', () {
final builder = TreeBuilder(repo, tree);
final builder = TreeBuilder(repo: repo, tree: tree);
expect(builder.length, 4);
builder.clear();
@ -51,12 +51,13 @@ void main() {
});
test('successfully builds the tree builder from entry of tree', () {
final builder = TreeBuilder(repo);
final builder = TreeBuilder(repo: repo);
final entry = tree.entries[0];
expect(() => builder[entry.name], throwsA(isA<ArgumentError>()));
builder.add(entry.name, entry.id, entry.filemode);
builder.add(
filename: entry.name, oid: entry.id, filemode: entry.filemode);
expect(builder[entry.name].name, entry.name);
builder.free();
@ -64,7 +65,7 @@ void main() {
});
test('successfully removes an entry', () {
final builder = TreeBuilder(repo, tree);
final builder = TreeBuilder(repo: repo, tree: tree);
expect(builder.length, tree.length);