refactor: use loops inside list literals (#60)

lib/src/bindings/remote.dart

@@ -13,10 +13,10 @@ List<String> list(Pointer<git_repository> repo) {
   final out = calloc<git_strarray>();
   libgit2.git_remote_list(out, repo);
 
-  final result = <String>[];
+  final result = <String>[
-  for (var i = 0; i < out.ref.count; i++) {
+    for (var i = 0; i < out.ref.count; i++)
-    result.add(out.ref.strings[i].cast<Utf8>().toDartString());
+      out.ref.strings[i].cast<Utf8>().toDartString()
-  }
+  ];
 
   calloc.free(out);
 
@@ -162,11 +162,13 @@ List<String> rename({
     calloc.free(out);
     throw LibGit2Error(libgit2.git_error_last());
   } else {
-    final result = <String>[];
+    final result = <String>[
-    for (var i = 0; i < out.ref.count; i++) {
+      for (var i = 0; i < out.ref.count; i++)
-      result.add(out.ref.strings[i].cast<Utf8>().toDartString());
+        out.ref.strings[i].cast<Utf8>().toDartString()
-    }
+    ];
+
     calloc.free(out);
+
     return result;
   }
 }
@@ -253,11 +255,13 @@ List<String> fetchRefspecs(Pointer<git_remote> remote) {
   final out = calloc<git_strarray>();
   libgit2.git_remote_get_fetch_refspecs(out, remote);
 
-  final result = <String>[];
+  final result = <String>[
-  for (var i = 0; i < out.ref.count; i++) {
+    for (var i = 0; i < out.ref.count; i++)
-    result.add(out.ref.strings[i].cast<Utf8>().toDartString());
+      out.ref.strings[i].cast<Utf8>().toDartString()
-  }
+  ];
+
   calloc.free(out);
+
   return result;
 }
 
@@ -266,11 +270,13 @@ List<String> pushRefspecs(Pointer<git_remote> remote) {
   final out = calloc<git_strarray>();
   libgit2.git_remote_get_push_refspecs(out, remote);
 
-  final result = <String>[];
+  final result = <String>[
-  for (var i = 0; i < out.ref.count; i++) {
+    for (var i = 0; i < out.ref.count; i++)
-    result.add(out.ref.strings[i].cast<Utf8>().toDartString());
+      out.ref.strings[i].cast<Utf8>().toDartString()
-  }
+  ];
+
   calloc.free(out);
+
   return result;
 }
 

lib/src/bindings/repository.dart

@@ -124,7 +124,6 @@ Pointer<git_repository> clone({
   required String localPath,
   required bool bare,
   RemoteCallback? remoteCallback,
-  // Repository Function(String, bool)? repository,
   RepositoryCallback? repositoryCallback,
   String? checkoutBranch,
   required Callbacks callbacks,

lib/src/bindings/worktree.dart

@@ -110,11 +110,13 @@ List<String> list(Pointer<git_repository> repo) {
     calloc.free(out);
     throw LibGit2Error(libgit2.git_error_last());
   } else {
-    final result = <String>[];
+    final result = <String>[
-    for (var i = 0; i < out.ref.count; i++) {
+      for (var i = 0; i < out.ref.count; i++)
-      result.add(out.ref.strings[i].cast<Utf8>().toDartString());
+        out.ref.strings[i].cast<Utf8>().toDartString()
-    }
+    ];
+
     calloc.free(out);
+
     return result;
   }
 }

lib/src/commit.dart

@@ -264,18 +264,11 @@ class Commit extends Equatable {
 
   /// List of parent commits [Oid]s.
   List<Oid> get parents {
-    final parents = <Oid>[];
     final parentCount = bindings.parentCount(_commitPointer);
-
+    return <Oid>[
-    for (var i = 0; i < parentCount; i++) {
+      for (var i = 0; i < parentCount; i++)
-      final parentOid = bindings.parentId(
+        Oid(bindings.parentId(commitPointer: _commitPointer, position: i))
-        commitPointer: _commitPointer,
+    ];
-        position: i,
-      );
-      parents.add(Oid(parentOid));
-    }
-
-    return parents;
   }
 
   /// Returns the specified parent of the commit at provided 0-based [position].

lib/src/diff.dart

@@ -285,28 +285,18 @@ class Diff extends Equatable {
   /// revisions.
   List<DiffDelta> get deltas {
     final length = bindings.length(_diffPointer);
-    final deltas = <DiffDelta>[];
+    return <DiffDelta>[
-    for (var i = 0; i < length; i++) {
+      for (var i = 0; i < length; i++)
-      deltas.add(
+        DiffDelta(bindings.getDeltaByIndex(diffPointer: _diffPointer, index: i))
-        DiffDelta(
+    ];
-          bindings.getDeltaByIndex(
-            diffPointer: _diffPointer,
-            index: i,
-          ),
-        ),
-      );
-    }
-    return deltas;
   }
 
   /// A List of [Patch]es.
   List<Patch> get patches {
     final length = bindings.length(_diffPointer);
-    final patches = <Patch>[];
+    return <Patch>[
-    for (var i = 0; i < length; i++) {
+      for (var i = 0; i < length; i++) Patch.fromDiff(diff: this, index: i)
-      patches.add(Patch.fromDiff(diff: this, index: i));
+    ];
-    }
-    return patches;
   }
 
   /// The patch diff text.

lib/src/patch.dart

@@ -237,10 +237,10 @@ class Patch extends Equatable {
         );
       }
 
-      final intHeader = <int>[];
+      final intHeader = <int>[
-      for (var i = 0; i < hunkPointer.ref.header_len; i++) {
+        for (var i = 0; i < hunkPointer.ref.header_len; i++)
-        intHeader.add(hunkPointer.ref.header[i]);
+          hunkPointer.ref.header[i]
-      }
+      ];
 
       hunks.add(
         DiffHunk._(

lib/src/rebase.dart

@@ -47,18 +47,13 @@ class Rebase {
 
   /// List of operations that are to be applied.
   List<RebaseOperation> get operations {
-    final result = <RebaseOperation>[];
     final operationsCount = bindings.operationsCount(_rebasePointer);
-
+    return <RebaseOperation>[
-    for (var i = 0; i < operationsCount; i++) {
+      for (var i = 0; i < operationsCount; i++)
-      final operation = bindings.getOperationByIndex(
+        RebaseOperation._(
-        rebase: _rebasePointer,
+          bindings.getOperationByIndex(rebase: _rebasePointer, index: i),
-        index: i,
+        )
-      );
+    ];
-      result.add(RebaseOperation._(operation));
-    }
-
-    return result;
   }
 
   /// Index of the rebase operation that is currently being applied. If the

lib/src/reference.dart

@@ -203,14 +203,9 @@ class Reference extends Equatable {
   ///
   /// Throws an [Exception] if error occured.
   Oid get target {
-    late final Pointer<git_oid> oidPointer;
+    return type == ReferenceType.direct
-
+        ? Oid(bindings.target(_refPointer))
-    if (type == ReferenceType.direct) {
+        : Oid(bindings.target(bindings.resolve(_refPointer)));
-      oidPointer = bindings.target(_refPointer);
-    } else {
-      oidPointer = bindings.target(bindings.resolve(_refPointer));
-    }
-    return Oid(oidPointer);
   }
 
   /// Recursively peel reference until object of the specified [type] is found.

lib/src/remote.dart

@@ -211,20 +211,16 @@ class Remote extends Equatable {
     final refs = bindings.lsRemotes(_remotePointer);
     bindings.disconnect(_remotePointer);
 
-    final result = <RemoteReference>[];
+    return <RemoteReference>[
-    for (final ref in refs) {
+      for (final ref in refs)
-      result.add(
         RemoteReference._(
           isLocal: ref['local']! as bool,
           localId: ref['loid'] as Oid?,
           name: ref['name']! as String,
           oid: ref['oid']! as Oid,
           symRef: ref['symref']! as String,
-        ),
+        )
-      );
+    ];
-    }
-
-    return result;
   }
 
   /// Downloads new data and updates tips.

lib/src/revparse.dart

@@ -22,11 +22,9 @@ class RevParse {
       spec: spec,
     );
     object = Commit(pointers[0].cast<git_commit>());
-    if (pointers.length == 2) {
+    reference = pointers.length == 2
-      reference = Reference(pointers[1].cast<git_reference>());
+        ? Reference(pointers[1].cast<git_reference>())
-    } else {
+        : null;
-      reference = null;
-    }
   }
 
   /// Object found by a revision string.

lib/src/stash.dart

@@ -43,14 +43,12 @@ class Stash extends Equatable {
     String? message,
     Set<GitStash> flags = const {GitStash.defaults},
   }) {
-    final flagsInt = flags.fold(0, (int acc, e) => acc | e.value);
-
     return Oid(
       bindings.save(
         repoPointer: repo.pointer,
         stasherPointer: stasher.pointer,
         message: message,
-        flags: flagsInt,
+        flags: flags.fold(0, (int acc, e) => acc | e.value),
       ),
     );
   }

lib/src/tag.dart

@@ -208,11 +208,7 @@ class Tag extends Equatable {
   /// Tagger (author) of a tag if there is one.
   Signature? get tagger {
     final sigPointer = bindings.tagger(_tagPointer);
-    if (sigPointer != nullptr) {
+    return sigPointer != nullptr ? Signature(sigPointer) : null;
-      return Signature(sigPointer);
-    } else {
-      return null;
-    }
   }
 
   /// Releases memory allocated for tag object.

lib/src/tree.dart

@@ -35,19 +35,10 @@ class Tree extends Equatable {
   /// List with tree entries of a tree.
   List<TreeEntry> get entries {
     final entryCount = bindings.entryCount(_treePointer);
-    final result = <TreeEntry>[];
+    return <TreeEntry>[
-    for (var i = 0; i < entryCount; i++) {
+      for (var i = 0; i < entryCount; i++)
-      result.add(
+        TreeEntry(bindings.getByIndex(treePointer: _treePointer, index: i))
-        TreeEntry(
+    ];
-          bindings.getByIndex(
-            treePointer: _treePointer,
-            index: i,
-          ),
-        ),
-      );
-    }
-
-    return result;
   }
 
   /// Lookups a tree entry in the tree.