feat(commit): make 'updateRef' to be required argument

This commit is contained in:
Aleksey Kulikov 2021-11-02 18:00:15 +03:00
parent 678f6208f6
commit c2da51af94
4 changed files with 27 additions and 20 deletions

View file

@ -65,7 +65,7 @@ void annotatedFree(Pointer<git_annotated_commit> commit) {
/// Throws a [LibGit2Error] if error occured.
Pointer<git_oid> create({
required Pointer<git_repository> repoPointer,
String? updateRef,
required String updateRef,
required Pointer<git_signature> authorPointer,
required Pointer<git_signature> committerPointer,
String? messageEncoding,
@ -75,7 +75,7 @@ Pointer<git_oid> create({
required List<Pointer<git_commit>> parents,
}) {
final out = calloc<git_oid>();
final updateRefC = updateRef?.toNativeUtf8().cast<Int8>() ?? nullptr;
final updateRefC = updateRef.toNativeUtf8().cast<Int8>();
final messageEncodingC =
messageEncoding?.toNativeUtf8().cast<Int8>() ?? nullptr;
final messageC = message.toNativeUtf8().cast<Int8>();

View file

@ -58,7 +58,7 @@ class Commit {
/// Throws a [LibGit2Error] if error occured.
static Oid create({
required Repository repo,
String? updateRef,
required String updateRef,
required Signature author,
required Signature committer,
String? messageEncoding,
@ -103,10 +103,10 @@ class Commit {
static Oid amend({
required Repository repo,
required Commit commit,
required String? updateRef,
Signature? author,
Signature? committer,
Tree? tree,
String? updateRef,
String? message,
String? messageEncoding,
}) {

View file

@ -558,8 +558,8 @@ class Repository {
/// this commit. If the reference is not direct, it will be resolved to a
/// direct reference. Use "HEAD" to update the HEAD of the current branch and
/// make it point to this commit. If the reference doesn't exist yet, it will
/// be created. If it does exist, the first parent
/// must be the tip of this branch.
/// be created. If it does exist, the first parent must be the tip of this
/// branch.
///
/// [author] is the signature with author and author time of commit.
///
@ -580,21 +580,23 @@ class Repository {
///
/// Throws a [LibGit2Error] if error occured.
Oid createCommit({
required String updateRef,
required String message,
required Signature author,
required Signature commiter,
required Tree tree,
required List<Commit> parents,
String? updateRef,
String? messageEncoding,
}) {
return Commit.create(
repo: this,
updateRef: updateRef,
message: message,
author: author,
committer: commiter,
tree: tree,
parents: parents,
messageEncoding: messageEncoding,
);
}
@ -619,20 +621,20 @@ class Repository {
/// Throws a [LibGit2Error] if error occured.
Oid amendCommit({
required Commit commit,
required String? updateRef,
Signature? author,
Signature? committer,
Tree? tree,
String? updateRef,
String? message,
String? messageEncoding,
}) {
return Commit.amend(
repo: this,
commit: commit,
updateRef: updateRef,
author: author,
committer: committer,
tree: tree,
updateRef: updateRef,
message: message,
messageEncoding: messageEncoding,
);