feat(reference): add ability to rename reference

This commit is contained in:
Aleksey Kulikov 2021-08-06 18:57:21 +03:00
parent 30359f04d6
commit cfc6d0412b
3 changed files with 132 additions and 1 deletions

View file

@ -82,6 +82,46 @@ String shorthand(Pointer<git_reference> ref) {
return result.cast<Utf8>().toDartString();
}
/// Rename an existing reference.
///
/// This method works for both direct and symbolic references.
///
/// The new name will be checked for validity.
///
/// If the force flag is not enabled, and there's already a reference with the given name,
/// the renaming will fail.
///
/// IMPORTANT: The user needs to write a proper reflog entry if the reflog is enabled for
/// the repository. We only rename the reflog if it exists.
///
/// Throws a [LibGit2Error] if error occured.
Pointer<git_reference> rename(
Pointer<git_reference> ref,
String newName,
bool force,
String? logMessage,
) {
final out = calloc<Pointer<git_reference>>();
final newNameC = newName.toNativeUtf8().cast<Int8>();
final forceC = force == true ? 1 : 0;
final logMessageC = logMessage?.toNativeUtf8().cast<Int8>() ?? nullptr;
final error = libgit2.git_reference_rename(
out,
ref,
newNameC,
forceC,
logMessageC,
);
calloc.free(newNameC);
calloc.free(logMessageC);
if (error < 0) {
throw LibGit2Error(libgit2.git_error_last());
} else {
return out.value;
}
}
/// Fill a list with all the references that can be found in a repository.
///
/// The string array will be filled with the names of all references;

View file

@ -171,6 +171,23 @@ class Reference {
/// If no shortname is appropriate, it will return the full name.
String get shorthand => bindings.shorthand(_refPointer);
/// Renames an existing reference.
///
/// This method works for both direct and symbolic references.
///
/// The new name will be checked for validity.
///
/// If the force flag is not enabled, and there's already a reference with the given name,
/// the renaming will fail.
///
/// IMPORTANT: The user needs to write a proper reflog entry if the reflog is enabled for
/// the repository. We only rename the reflog if it exists.
///
/// Throws a [LibGit2Error] if error occured.
void rename(String newName, {bool force = false, String? logMessage}) {
_refPointer = bindings.rename(_refPointer, newName, force, logMessage);
}
/// Returns a list with all the references that can be found in a repository.
///
/// Throws a [LibGit2Error] if error occured.

View file

@ -358,7 +358,7 @@ void main() {
ref.free();
});
group('setTarget()', () {
group('.setTarget()', () {
test('successfully sets target with SHA hex', () {
final ref = repo.getReference('refs/heads/master');
ref.setTarget(newCommit);
@ -418,6 +418,80 @@ void main() {
});
});
group('.rename()', () {
test('successfully renames reference', () {
final ref = repo.createReference(
name: 'refs/tags/v1',
target: lastCommit,
);
expect(ref.name, 'refs/tags/v1');
ref.rename('refs/tags/v2');
expect(ref.name, 'refs/tags/v2');
ref.delete();
ref.free();
});
test('throws on invalid name', () {
final ref = repo.createReference(
name: 'refs/tags/v1',
target: lastCommit,
);
expect(
() => ref.rename('refs/tags/invalid~'),
throwsA(isA<LibGit2Error>()),
);
ref.delete();
ref.free();
});
test('throws if name already exists', () {
final ref1 = repo.createReference(
name: 'refs/tags/v1',
target: lastCommit,
);
final ref2 = repo.createReference(
name: 'refs/tags/v2',
target: lastCommit,
);
expect(
() => ref1.rename('refs/tags/v2'),
throwsA(isA<LibGit2Error>()),
);
ref1.delete();
ref2.delete();
ref1.free();
ref2.free();
});
test('successfully renames with force flag set to true', () {
final ref1 = repo.createReference(
name: 'refs/tags/v1',
target: lastCommit,
);
final ref2 = repo.createReference(
name: 'refs/tags/v2',
target: newCommit,
);
expect(ref2.target.sha, newCommit);
ref1.rename('refs/tags/v2', force: true);
expect(ref1.name, 'refs/tags/v2');
ref1.delete();
ref1.free();
ref2.free();
});
});
group('isValidName()', () {
test('returns true for valid names', () {
expect(Reference.isValidName('HEAD'), true);