style: no implicit casts and dynamic

This commit is contained in:
Aleksey Kulikov 2021-10-22 17:25:06 +03:00
parent 7b14ee6b9b
commit f3fbc80f8e
11 changed files with 49 additions and 36 deletions

View file

@ -37,7 +37,7 @@ void head({
);
for (final p in pathPointers as List) {
calloc.free(p);
calloc.free(p as Pointer);
}
calloc.free(strArray as Pointer);
calloc.free(optsC);
@ -72,7 +72,7 @@ void index({
);
for (final p in pathPointers as List) {
calloc.free(p);
calloc.free(p as Pointer);
}
calloc.free(strArray as Pointer);
calloc.free(optsC);
@ -109,7 +109,7 @@ void tree({
);
for (final p in pathPointers as List) {
calloc.free(p);
calloc.free(p as Pointer);
}
calloc.free(strArray as Pointer);
calloc.free(optsC);

View file

@ -91,7 +91,7 @@ List revParseExt({
calloc.free(referenceOut);
throw LibGit2Error(libgit2.git_error_last());
} else {
var result = [];
var result = <Pointer>[];
result.add(objectOut.value);
if (referenceOut.value != nullptr) {
result.add(referenceOut.value);

View file

@ -70,7 +70,7 @@ void apply({
final error = libgit2.git_stash_apply(repoPointer, index, options);
for (final p in pathPointers as List) {
calloc.free(p);
calloc.free(p as Pointer);
}
calloc.free(strArray as Pointer);
calloc.free(optsC);
@ -125,7 +125,7 @@ void pop({
final error = libgit2.git_stash_pop(repoPointer, index, options);
for (final p in pathPointers as List) {
calloc.free(p);
calloc.free(p as Pointer);
}
calloc.free(strArray as Pointer);
calloc.free(optsC);

View file

@ -58,28 +58,36 @@ class Oid {
0);
}
bool operator <(other) {
return (other is Oid) &&
(bindings.compare(aPointer: _oidPointer, bPointer: other._oidPointer) ==
-1);
bool operator <(Oid other) {
return bindings.compare(
aPointer: _oidPointer,
bPointer: other._oidPointer,
) ==
-1;
}
bool operator <=(other) {
return (other is Oid) &&
(bindings.compare(aPointer: _oidPointer, bPointer: other._oidPointer) ==
-1);
bool operator <=(Oid other) {
return bindings.compare(
aPointer: _oidPointer,
bPointer: other._oidPointer,
) ==
-1;
}
bool operator >(other) {
return (other is Oid) &&
(bindings.compare(aPointer: _oidPointer, bPointer: other._oidPointer) ==
1);
bool operator >(Oid other) {
return bindings.compare(
aPointer: _oidPointer,
bPointer: other._oidPointer,
) ==
1;
}
bool operator >=(other) {
return (other is Oid) &&
(bindings.compare(aPointer: _oidPointer, bPointer: other._oidPointer) ==
1);
bool operator >=(Oid other) {
return bindings.compare(
aPointer: _oidPointer,
bPointer: other._oidPointer,
) ==
1;
}
@override // coverage:ignore-line

View file

@ -648,7 +648,7 @@ class Repository {
Index revertCommit({
required Commit revertCommit,
required Commit ourCommit,
mainline = 0,
int mainline = 0,
}) {
return Index(commit_bindings.revertCommit(
repoPointer: _repoPointer,
@ -986,7 +986,7 @@ class Repository {
head.free();
ref.free();
return [analysisSet, mergePreference];
return <Object>[analysisSet, mergePreference];
}
/// Merges the given commit [oid] into HEAD, writing the results into the

View file

@ -23,9 +23,11 @@ class RevParse {
repoPointer: repo.pointer,
spec: spec,
);
object = Commit(pointers[0].cast<git_commit>());
object = Commit(pointers[0].cast<git_commit>() as Pointer<git_commit>);
if (pointers.length == 2) {
reference = Reference(pointers[1].cast<git_reference>());
reference = Reference(
pointers[1].cast<git_reference>() as Pointer<git_reference>,
);
} else {
reference = null;
}