Siklos/libgit2dart
1
0
Fork 0
mirror of https://github.com/SkinnyMind/libgit2dart.git synced 2025-05-05 12:49:08 -04:00
Code Issues Projects Releases Wiki Activity

refactor: pass sha hex string instead of Oid as argument

Browse source
This commit is contained in:
Aleksey Kulikov 2021-09-04 12:21:42 +03:00
parent 2cf974c624
commit fb69de66d2
5 changed files with 25 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

17
lib/src/repository.dart
View file

@ -350,14 +350,17 @@ class Repository {
}
}
/// Returns the list of commits starting from provided [oid].
/// Returns the list of commits starting from provided [sha] hex string.
///
/// If [sorting] isn't provided default will be used (reverse chronological order, like in git).
List<Commit> log(Oid oid, [List<GitSort>? sorting]) {
List<Commit> log(String sha, [List<GitSort>? sorting]) {
final oid = Oid.fromSHA(this, sha);
final walker = RevWalk(this);
walker.sorting(sorting ?? [GitSort.none]);
walker.push(oid);
final result = walker.walk();
walker.free();
return result;
@ -397,11 +400,13 @@ class Repository {
/// Finds a merge base between two commits.
///
/// Throws a [LibGit2Error] if error occured.
Oid mergeBase(Oid one, Oid two) {
Oid mergeBase(String one, String two) {
final oidOne = Oid.fromSHA(this, one);
final oidTwo = Oid.fromSHA(this, two);
return Oid(merge_bindings.mergeBase(
_repoPointer,
one.pointer,
two.pointer,
oidOne.pointer,
oidTwo.pointer,
));
}
@ -436,7 +441,7 @@ class Repository {
/// Throws a [LibGit2Error] if error occured.
Oid createTag({
required String tagName,
required Oid target,
required String target,
required GitObject targetType,
required Signature tagger,
required String message,