Merged PR 163: Remove the static form + rename some components for clarity

The static form is hard to maintain so I am removing it + rename some components for clarity + moved some utils files

src/Components/App/Actions/Load.ts

@@ -1,6 +1,6 @@
 import { Dispatch, SetStateAction } from 'react';
-import { Revive } from '../../utils/saveload';
-import { IEditorState } from '../../Interfaces/IEditorState';
+import { IEditorState } from '../../../Interfaces/IEditorState';
+import { Revive } from '../../../utils/saveload';
 
 export function LoadState(
   editorState: IEditorState,

src/Components/App/Actions/MenuActions.ts

@@ -1,10 +1,10 @@
 import { Dispatch, SetStateAction } from 'react';
-import { IConfiguration } from '../../Interfaces/IConfiguration';
-import { ContainerModel } from '../../Interfaces/IContainerModel';
-import { fetchConfiguration } from '../API/api';
-import { IEditorState } from '../../Interfaces/IEditorState';
+import { IConfiguration } from '../../../Interfaces/IConfiguration';
+import { ContainerModel } from '../../../Interfaces/IContainerModel';
+import { fetchConfiguration } from '../../API/api';
+import { IEditorState } from '../../../Interfaces/IEditorState';
 import { LoadState } from './Load';
-import { DEFAULT_MAINCONTAINER_PROPS } from '../../utils/default';
+import { DEFAULT_MAINCONTAINER_PROPS } from '../../../utils/default';
 
 export function NewEditor(
   setEditorState: Dispatch<SetStateAction<IEditorState>>,

src/Components/App/App.tsx

@@ -4,8 +4,8 @@ import { MainMenu } from '../MainMenu/MainMenu';
 import { ContainerModel } from '../../Interfaces/IContainerModel';
 import Editor from '../Editor/Editor';
 import { IEditorState } from '../../Interfaces/IEditorState';
-import { LoadState } from './Load';
-import { LoadEditor, NewEditor } from './MenuActions';
+import { LoadState } from './Actions/Load';
+import { LoadEditor, NewEditor } from './Actions/MenuActions';
 import { DEFAULT_CONFIG, DEFAULT_MAINCONTAINER_PROPS } from '../../utils/default';
 
 // App will never have props

src/Components/ContainerProperties/ContainerForm.tsx

@@ -8,7 +8,7 @@ import { InputGroup } from '../InputGroup/InputGroup';
 import { RadioGroupButtons } from '../RadioGroupButtons/RadioGroupButtons';
 import { Select } from '../Select/Select';
 
-interface IDynamicFormProps {
+interface IContainerFormProps {
   properties: IContainerProperties
   symbols: Map<string, ISymbolModel>
   onChange: (key: string, value: string | number | boolean, isStyle?: boolean) => void
@@ -34,7 +34,7 @@ const getCSSInputs = (
   return groupInput;
 };
 
-const DynamicForm: React.FunctionComponent<IDynamicFormProps> = (props) => {
+const ContainerForm: React.FunctionComponent<IContainerFormProps> = (props) => {
   return (
     <div className='grid grid-cols-2 gap-y-4'>
       <InputGroup
@@ -181,5 +181,4 @@ const DynamicForm: React.FunctionComponent<IDynamicFormProps> = (props) => {
   );
 };
 
-
-export default DynamicForm;
+export default ContainerForm;

src/Components/ContainerProperties/ContainerProperties.test.tsx

@@ -3,14 +3,13 @@ import * as React from 'react';
 import { expect, describe, it, vi } from 'vitest';
 import { XPositionReference } from '../../Enums/XPositionReference';
 import IContainerProperties from '../../Interfaces/IContainerProperties';
-import { Properties } from './Properties';
+import { Properties } from './ContainerProperties';
 
 describe.concurrent('Properties', () => {
   it('No properties', () => {
     render(<Properties
       properties={undefined}
       onChange={() => {}}
-      onSubmit={() => {}}
       symbols={new Map()}
     />);
 
@@ -43,7 +42,6 @@ describe.concurrent('Properties', () => {
     const { container, rerender } = render(<Properties
       properties={prop}
       onChange={handleChange}
-      onSubmit={() => {}}
       symbols={new Map()}
     />);
 
@@ -78,7 +76,6 @@ describe.concurrent('Properties', () => {
     rerender(<Properties
       properties={Object.assign({}, prop)}
       onChange={handleChange}
-      onSubmit={() => {}}
       symbols={new Map()}
     />);
 

src/Components/ContainerProperties/ContainerProperties.tsx

@@ -1,38 +1,25 @@
-import React, { useState } from 'react';
+import React from 'react';
 import IContainerProperties from '../../Interfaces/IContainerProperties';
 import { ISymbolModel } from '../../Interfaces/ISymbolModel';
-import { ToggleButton } from '../ToggleButton/ToggleButton';
-import { Form } from './Form';
+import ContainerForm from './ContainerForm';
 
 interface IPropertiesProps {
   properties?: IContainerProperties
   symbols: Map<string, ISymbolModel>
   onChange: (key: string, value: string | number | boolean, isStyle?: boolean) => void
-  onSubmit: (event: React.FormEvent<HTMLFormElement>) => void
 }
 
 export const Properties: React.FC<IPropertiesProps> = (props: IPropertiesProps) => {
-  const [isDynamicInput, setIsDynamicInput] = useState<boolean>(true);
-
   if (props.properties === undefined) {
     return <div></div>;
   }
 
   return (
     <div className='h-3/5 p-3 bg-slate-200 overflow-y-auto'>
-      <ToggleButton
-        id='isDynamic'
-        text='Dynamic update'
-        title='Enable dynamic svg update'
-        checked={isDynamicInput}
-        onChange={() => setIsDynamicInput(!isDynamicInput)}
-      />
-      <Form
+      <ContainerForm
         properties={props.properties}
         symbols={props.symbols}
-        isDynamicInput={isDynamicInput}
         onChange={props.onChange}
-        onSubmit={props.onSubmit}
       />
     </div>
   );

src/Components/Editor/Actions/ContainerOperations.ts

@@ -1,14 +1,14 @@
 import { Dispatch, SetStateAction } from 'react';
-import { IHistoryState } from '../../Interfaces/IHistoryState';
-import { IConfiguration } from '../../Interfaces/IConfiguration';
-import { ContainerModel, IContainerModel } from '../../Interfaces/IContainerModel';
-import { findContainerById, MakeIterator } from '../../utils/itertools';
-import { getCurrentHistory, UpdateCounters } from './Editor';
-import { AddMethod } from '../../Enums/AddMethod';
-import { IAvailableContainer } from '../../Interfaces/IAvailableContainer';
-import { GetDefaultContainerProps, DEFAULTCHILDTYPE_ALLOW_CYCLIC, DEFAULTCHILDTYPE_MAX_DEPTH } from '../../utils/default';
-import { ApplyBehaviors } from './Behaviors/Behaviors';
-import { ISymbolModel } from '../../Interfaces/ISymbolModel';
+import { IHistoryState } from '../../../Interfaces/IHistoryState';
+import { IConfiguration } from '../../../Interfaces/IConfiguration';
+import { ContainerModel, IContainerModel } from '../../../Interfaces/IContainerModel';
+import { findContainerById, MakeIterator } from '../../../utils/itertools';
+import { getCurrentHistory, UpdateCounters } from '../Editor';
+import { AddMethod } from '../../../Enums/AddMethod';
+import { IAvailableContainer } from '../../../Interfaces/IAvailableContainer';
+import { GetDefaultContainerProps, DEFAULTCHILDTYPE_ALLOW_CYCLIC, DEFAULTCHILDTYPE_MAX_DEPTH } from '../../../utils/default';
+import { ApplyBehaviors } from '../Behaviors/Behaviors';
+import { ISymbolModel } from '../../../Interfaces/ISymbolModel';
 
 /**
  * Select a container
@@ -71,7 +71,8 @@ export function DeleteContainer(
   if (container === null || container === undefined) {
     throw new Error('[DeleteContainer] Container model was not found among children of the main container!');
   }
-  const newSymbols = structuredClone(current.Symbols)
+
+  const newSymbols = structuredClone(current.Symbols);
   UnlinkSymbol(newSymbols, container);
 
   const index = container.parent.children.indexOf(container);
@@ -83,10 +84,12 @@ export function DeleteContainer(
 
   // Select the previous container
   // or select the one above
-  const SelectedContainer = findContainerById(mainContainerClone, current.SelectedContainerId) ??
-    container.parent.children.at(index - 1) ??
-    container.parent;
-  const SelectedContainerId = SelectedContainer.properties.id;
+  const SelectedContainerId = GetSelectedContainerOnDelete(
+    mainContainerClone,
+    current.SelectedContainerId,
+    container.parent,
+    index
+  );
 
   history.push({
     LastAction: `Delete ${containerId}`,
@@ -100,6 +103,14 @@ export function DeleteContainer(
   setHistoryCurrentStep(history.length - 1);
 }
 
+function GetSelectedContainerOnDelete(mainContainerClone: IContainerModel, selectedContainerId: string, parent: IContainerModel, index: number): string {
+  const SelectedContainer = findContainerById(mainContainerClone, selectedContainerId) ??
+    parent.children.at(index - 1) ??
+    parent;
+  const SelectedContainerId = SelectedContainer.properties.id;
+  return SelectedContainerId;
+}
+
 function UnlinkSymbol(symbols: Map<string, ISymbolModel>, container: IContainerModel): void {
   const it = MakeIterator(container);
   for (const child of it) {
@@ -327,3 +338,82 @@ function ApplyAddMethod(index: number, containerConfig: IAvailableContainer, par
   }
   return x;
 }
+
+/**
+  * Handled the property change event in the properties form
+  * @param key Property name
+  * @param value New value of the property
+  * @returns void
+  */
+export function OnPropertyChange(
+  key: string,
+  value: string | number | boolean,
+  isStyle: boolean = false,
+  selected: IContainerModel | undefined,
+  fullHistory: IHistoryState[],
+  historyCurrentStep: number,
+  setHistory: Dispatch<SetStateAction<IHistoryState[]>>,
+  setHistoryCurrentStep: Dispatch<SetStateAction<number>>
+): void {
+  const history = getCurrentHistory(fullHistory, historyCurrentStep);
+  const current = history[history.length - 1];
+
+  if (selected === null ||
+      selected === undefined) {
+    throw new Error('[OnPropertyChange] Property was changed before selecting a Container');
+  }
+
+  const mainContainerClone: IContainerModel = structuredClone(current.MainContainer);
+  const container: ContainerModel | undefined = findContainerById(mainContainerClone, selected.properties.id);
+
+  if (container === null || container === undefined) {
+    throw new Error('[OnPropertyChange] Container model was not found among children of the main container!');
+  }
+
+  const oldSymbolId = container.properties.linkedSymbolId;
+
+  if (isStyle) {
+    (container.properties.style as any)[key] = value;
+  } else {
+    (container.properties as any)[key] = value;
+  }
+
+  LinkSymbol(
+    container.properties.id,
+    oldSymbolId,
+    container.properties.linkedSymbolId,
+    current.Symbols
+  );
+
+  ApplyBehaviors(container, current.Symbols);
+
+  history.push({
+    LastAction: `Change ${key} of ${container.properties.id}`,
+    MainContainer: mainContainerClone,
+    SelectedContainerId: container.properties.id,
+    TypeCounters: Object.assign({}, current.TypeCounters),
+    Symbols: structuredClone(current.Symbols),
+    SelectedSymbolId: current.SelectedSymbolId
+  });
+  setHistory(history);
+  setHistoryCurrentStep(history.length - 1);
+}
+
+function LinkSymbol(
+  containerId: string,
+  oldSymbolId: string,
+  newSymbolId: string,
+  symbols: Map<string, ISymbolModel>
+): void {
+  const oldSymbol = symbols.get(oldSymbolId);
+  const newSymbol = symbols.get(newSymbolId);
+
+  if (newSymbol === undefined) {
+    if (oldSymbol !== undefined) {
+      oldSymbol.linkedContainers.delete(containerId);
+    }
+    return;
+  }
+
+  newSymbol.linkedContainers.add(containerId);
+}

src/Components/Editor/Actions/Save.ts

@@ -1,8 +1,8 @@
-import { IHistoryState } from '../../Interfaces/IHistoryState';
-import { IConfiguration } from '../../Interfaces/IConfiguration';
-import { getCircularReplacer } from '../../utils/saveload';
-import { ID } from '../SVG/SVG';
-import { IEditorState } from '../../Interfaces/IEditorState';
+import { IHistoryState } from '../../../Interfaces/IHistoryState';
+import { IConfiguration } from '../../../Interfaces/IConfiguration';
+import { getCircularReplacer } from '../../../utils/saveload';
+import { ID } from '../../SVG/SVG';
+import { IEditorState } from '../../../Interfaces/IEditorState';
 
 export function SaveEditorAsJSON(
   history: IHistoryState[],

src/Components/Editor/Actions/Shortcuts.ts

@@ -1,6 +1,6 @@
 import { Dispatch, SetStateAction } from 'react';
-import { IHistoryState } from '../../Interfaces/IHistoryState';
-import { ENABLE_SHORTCUTS } from '../../utils/default';
+import { IHistoryState } from '../../../Interfaces/IHistoryState';
+import { ENABLE_SHORTCUTS } from '../../../utils/default';
 
 export function onKeyDown(
   event: KeyboardEvent,

src/Components/Editor/Actions/SymbolOperations.ts

@@ -1,13 +1,13 @@
 import { Dispatch, SetStateAction } from 'react';
-import { IConfiguration } from '../../Interfaces/IConfiguration';
-import { IContainerModel } from '../../Interfaces/IContainerModel';
-import { IHistoryState } from '../../Interfaces/IHistoryState';
-import { ISymbolModel } from '../../Interfaces/ISymbolModel';
-import { DEFAULT_SYMBOL_HEIGHT, DEFAULT_SYMBOL_WIDTH } from '../../utils/default';
-import { findContainerById } from '../../utils/itertools';
-import { restoreX } from '../../utils/svg';
-import { ApplyBehaviors } from './Behaviors/Behaviors';
-import { getCurrentHistory, UpdateCounters } from './Editor';
+import { IConfiguration } from '../../../Interfaces/IConfiguration';
+import { IContainerModel } from '../../../Interfaces/IContainerModel';
+import { IHistoryState } from '../../../Interfaces/IHistoryState';
+import { ISymbolModel } from '../../../Interfaces/ISymbolModel';
+import { DEFAULT_SYMBOL_HEIGHT, DEFAULT_SYMBOL_WIDTH } from '../../../utils/default';
+import { findContainerById } from '../../../utils/itertools';
+import { restoreX } from '../../../utils/svg';
+import { ApplyBehaviors } from '../Behaviors/Behaviors';
+import { getCurrentHistory, UpdateCounters } from '../Editor';
 
 export function AddSymbol(
   name: string,

src/Components/Editor/Editor.tsx

@@ -4,14 +4,13 @@ import { IConfiguration } from '../../Interfaces/IConfiguration';
 import { SVG } from '../SVG/SVG';
 import { IHistoryState } from '../../Interfaces/IHistoryState';
 import { UI } from '../UI/UI';
-import { SelectContainer, DeleteContainer, AddContainerToSelectedContainer, AddContainer } from './ContainerOperations';
-import { SaveEditorAsJSON, SaveEditorAsSVG } from './Save';
-import { onKeyDown } from './Shortcuts';
-import { OnPropertyChange, OnPropertiesSubmit } from './PropertiesOperations';
+import { SelectContainer, DeleteContainer, AddContainerToSelectedContainer, AddContainer, OnPropertyChange } from './Actions/ContainerOperations';
+import { SaveEditorAsJSON, SaveEditorAsSVG } from './Actions/Save';
+import { onKeyDown } from './Actions/Shortcuts';
 import EditorEvents from '../../Events/EditorEvents';
 import { IEditorState } from '../../Interfaces/IEditorState';
 import { MAX_HISTORY } from '../../utils/default';
-import { AddSymbol, OnPropertyChange as OnSymbolPropertyChange, DeleteSymbol, SelectSymbol } from './SymbolOperations';
+import { AddSymbol, OnPropertyChange as OnSymbolPropertyChange, DeleteSymbol, SelectSymbol } from './Actions/SymbolOperations';
 import { findContainerById } from '../../utils/itertools';
 
 interface IEditorProps {
@@ -113,14 +112,6 @@ const Editor: React.FunctionComponent<IEditorProps> = (props) => {
           setHistory,
           setHistoryCurrentStep
         )}
-        OnPropertiesSubmit={(event) => OnPropertiesSubmit(
-          event,
-          selected,
-          history,
-          historyCurrentStep,
-          setHistory,
-          setHistoryCurrentStep
-        )}
         AddContainerToSelectedContainer={(type) => AddContainerToSelectedContainer(
           type,
           selected,

src/Components/Editor/PropertiesOperations.ts

@@ -1,223 +0,0 @@
-import { Dispatch, SetStateAction } from 'react';
-import { IContainerModel, ContainerModel } from '../../Interfaces/IContainerModel';
-import { IHistoryState } from '../../Interfaces/IHistoryState';
-import { findContainerById } from '../../utils/itertools';
-import { getCurrentHistory } from './Editor';
-import { ApplyBehaviors } from './Behaviors/Behaviors';
-import { restoreX } from '../../utils/svg';
-import { ISymbolModel } from '../../Interfaces/ISymbolModel';
-
-/**
-  * Handled the property change event in the properties form
-  * @param key Property name
-  * @param value New value of the property
-  * @returns void
-  */
-export function OnPropertyChange(
-  key: string,
-  value: string | number | boolean,
-  isStyle: boolean = false,
-  selected: IContainerModel | undefined,
-  fullHistory: IHistoryState[],
-  historyCurrentStep: number,
-  setHistory: Dispatch<SetStateAction<IHistoryState[]>>,
-  setHistoryCurrentStep: Dispatch<SetStateAction<number>>
-): void {
-  const history = getCurrentHistory(fullHistory, historyCurrentStep);
-  const current = history[history.length - 1];
-
-  if (selected === null ||
-      selected === undefined) {
-    throw new Error('[OnPropertyChange] Property was changed before selecting a Container');
-  }
-
-  const mainContainerClone: IContainerModel = structuredClone(current.MainContainer);
-  const container: ContainerModel | undefined = findContainerById(mainContainerClone, selected.properties.id);
-
-  if (container === null || container === undefined) {
-    throw new Error('[OnPropertyChange] Container model was not found among children of the main container!');
-  }
-
-  const oldSymbolId = container.properties.linkedSymbolId;
-
-  if (isStyle) {
-    (container.properties.style as any)[key] = value;
-  } else {
-    (container.properties as any)[key] = value;
-  }
-
-  LinkSymbol(
-    container.properties.id,
-    oldSymbolId,
-    container.properties.linkedSymbolId,
-    current.Symbols
-  );
-
-  ApplyBehaviors(container, current.Symbols);
-
-  history.push({
-    LastAction: `Change ${key} of ${container.properties.id}`,
-    MainContainer: mainContainerClone,
-    SelectedContainerId: container.properties.id,
-    TypeCounters: Object.assign({}, current.TypeCounters),
-    Symbols: structuredClone(current.Symbols),
-    SelectedSymbolId: current.SelectedSymbolId
-  });
-  setHistory(history);
-  setHistoryCurrentStep(history.length - 1);
-}
-
-function LinkSymbol(
-  containerId: string,
-  oldSymbolId: string,
-  newSymbolId: string,
-  symbols: Map<string, ISymbolModel>
-): void {
-  const oldSymbol = symbols.get(oldSymbolId);
-  const newSymbol = symbols.get(newSymbolId);
-
-  if (newSymbol === undefined) {
-    if (oldSymbol !== undefined) {
-      oldSymbol.linkedContainers.delete(containerId);
-    }
-    return;
-  }
-
-  newSymbol.linkedContainers.add(containerId);
-}
-
-/**
-  * Handled the property change event in the properties form
-  * @param key Property name
-  * @param properties Properties of the selected container
-  * @returns void
-  */
-export function OnPropertiesSubmit(
-  event: React.SyntheticEvent<HTMLFormElement>,
-  selected: IContainerModel | undefined,
-  fullHistory: IHistoryState[],
-  historyCurrentStep: number,
-  setHistory: Dispatch<SetStateAction<IHistoryState[]>>,
-  setHistoryCurrentStep: Dispatch<SetStateAction<number>>
-): void {
-  event.preventDefault();
-  const history = getCurrentHistory(fullHistory, historyCurrentStep);
-  const current = history[history.length - 1];
-
-  if (selected === null ||
-      selected === undefined) {
-    throw new Error('[OnPropertyChange] Property was changed before selecting a Container');
-  }
-
-  const mainContainerClone: IContainerModel = structuredClone(current.MainContainer);
-  const container: ContainerModel | undefined = findContainerById(mainContainerClone, selected.properties.id);
-
-  if (container === null || container === undefined) {
-    throw new Error('[OnPropertyChange] Container model was not found among children of the main container!');
-  }
-
-  // Assign container properties
-  const form: HTMLFormElement = event.target as HTMLFormElement;
-  for (const property in container.properties) {
-    const input: HTMLInputElement | HTMLDivElement | null = form.querySelector(`#${property}`);
-
-    if (input === null) {
-      continue;
-    }
-
-    if (input instanceof HTMLInputElement) {
-      submitHTMLInput(input, container, property, form);
-      continue;
-    }
-
-    if (input instanceof HTMLDivElement) {
-      submitRadioButtons(input, container, property);
-      continue;
-    }
-  }
-
-  // Assign cssproperties
-  for (const styleProperty in container.properties.style) {
-    submitCSSForm(form, styleProperty, container);
-  }
-
-  // Apply the behaviors
-  ApplyBehaviors(container, current.Symbols);
-
-  history.push({
-    LastAction: `Change properties of ${container.properties.id}`,
-    MainContainer: mainContainerClone,
-    SelectedContainerId: container.properties.id,
-    TypeCounters: Object.assign({}, current.TypeCounters),
-    Symbols: structuredClone(current.Symbols),
-    SelectedSymbolId: current.SelectedSymbolId
-  });
-  setHistory(history);
-  setHistoryCurrentStep(history.length - 1);
-}
-
-const submitHTMLInput = (
-  input: HTMLInputElement,
-  container: IContainerModel,
-  property: string,
-  form: HTMLFormElement
-): void => {
-  if (input.type !== 'number') {
-    (container.properties as any)[property] = input.value;
-    return;
-  }
-
-  if (property === 'x') {
-    // Hardcoded fix for XPositionReference
-    const x = RestoreX(form, input);
-    (container.properties as any)[property] = x;
-    return;
-  }
-
-  (container.properties as any)[property] = Number(input.value);
-};
-
-const submitCSSForm = (form: HTMLFormElement, styleProperty: string, container: ContainerModel): void => {
-  const input: HTMLInputElement | null = form.querySelector(`#${styleProperty}`);
-  if (input === null) {
-    return;
-  }
-  (container.properties.style as any)[styleProperty] = input.value;
-};
-
-const RestoreX = (
-  form: HTMLFormElement,
-  input: HTMLInputElement
-): number => {
-  const inputWidth: HTMLInputElement | null = form.querySelector('#width');
-  const inputRadio: HTMLDivElement | null = form.querySelector('#XPositionReference');
-  if (inputWidth === null || inputRadio === null) {
-    throw new Error('[OnPropertiesSubmit] Missing inputs for width or XPositionReference');
-  }
-
-  const radiobutton: HTMLInputElement | null = inputRadio.querySelector('input[name="XPositionReference"]:checked');
-  if (radiobutton === null) {
-    throw new Error('[OnPropertiesSubmit] Missing inputs for XPositionReference');
-  }
-
-  return restoreX(Number(input.value), Number(inputWidth.value), Number(radiobutton.value));
-};
-
-const submitRadioButtons = (
-  div: HTMLDivElement,
-  container: IContainerModel,
-  property: string
-): void => {
-  const radiobutton: HTMLInputElement | null = div.querySelector(`input[name="${property}"]:checked`);
-  if (radiobutton === null) {
-    return;
-  }
-
-  if (radiobutton.type === 'radio') {
-    (container.properties as any)[property] = Number(radiobutton.value);
-    return;
-  }
-
-  (container.properties as any)[property] = radiobutton.value;
-};
-

src/Components/ElementsSidebar/ElementsSidebar.test.tsx

@@ -33,7 +33,6 @@ describe.concurrent('Elements sidebar', () => {
       isHistoryOpen={false}
       SelectedContainer={undefined}
       OnPropertyChange={() => {}}
-      OnPropertiesSubmit={() => {}}
       SelectContainer={() => {}}
       DeleteContainer={() => {}}
       AddContainer={() => {}}
@@ -72,7 +71,6 @@ describe.concurrent('Elements sidebar', () => {
       isHistoryOpen={false}
       SelectedContainer={MainContainer}
       OnPropertyChange={() => {}}
-      OnPropertiesSubmit={() => {}}
       SelectContainer={() => {}}
       DeleteContainer={() => {}}
       AddContainer={() => {}}
@@ -178,7 +176,6 @@ describe.concurrent('Elements sidebar', () => {
       isHistoryOpen={false}
       SelectedContainer={MainContainer}
       OnPropertyChange={() => {}}
-      OnPropertiesSubmit={() => {}}
       SelectContainer={() => {}}
       DeleteContainer={() => {}}
       AddContainer={() => {}}
@@ -246,7 +243,6 @@ describe.concurrent('Elements sidebar', () => {
       isHistoryOpen={false}
       SelectedContainer={SelectedContainer}
       OnPropertyChange={() => {}}
-      OnPropertiesSubmit={() => {}}
       SelectContainer={selectContainer}
       DeleteContainer={() => {}}
       AddContainer={() => {}}
@@ -271,7 +267,6 @@ describe.concurrent('Elements sidebar', () => {
       isHistoryOpen={false}
       SelectedContainer={SelectedContainer}
       OnPropertyChange={() => {}}
-      OnPropertiesSubmit={() => {}}
       SelectContainer={selectContainer}
       DeleteContainer={() => {}}
       AddContainer={() => {}}

src/Components/ElementsSidebar/ElementsSidebar.tsx

@@ -1,6 +1,6 @@
 import * as React from 'react';
 import { FixedSizeList as List } from 'react-window';
-import { Properties } from '../Properties/Properties';
+import { Properties } from '../ContainerProperties/ContainerProperties';
 import { IContainerModel } from '../../Interfaces/IContainerModel';
 import { getDepth, MakeIterator } from '../../utils/itertools';
 import { Menu } from '../Menu/Menu';
@@ -16,7 +16,6 @@ interface IElementsSidebarProps {
   isHistoryOpen: boolean
   SelectedContainer: IContainerModel | undefined
   OnPropertyChange: (key: string, value: string | number | boolean, isStyle?: boolean) => void
-  OnPropertiesSubmit: (event: React.FormEvent<HTMLFormElement>) => void
   SelectContainer: (containerId: string) => void
   DeleteContainer: (containerid: string) => void
   AddContainer: (index: number, type: string, parent: string) => void
@@ -144,7 +143,6 @@ export const ElementsSidebar: React.FC<IElementsSidebarProps> = (props: IElement
         properties={props.SelectedContainer?.properties}
         symbols={props.symbols}
         onChange={props.OnPropertyChange}
-        onSubmit={props.OnPropertiesSubmit}
       />
     </div>
   );

src/Components/Properties/Form.tsx

@@ -1,27 +0,0 @@
-import * as React from 'react';
-import IContainerProperties from '../../Interfaces/IContainerProperties';
-import { ISymbolModel } from '../../Interfaces/ISymbolModel';
-import DynamicForm from './DynamicForm';
-import StaticForm from './StaticForm';
-
-interface IFormProps {
-  properties: IContainerProperties
-  symbols: Map<string, ISymbolModel>
-  isDynamicInput: boolean
-  onChange: (key: string, value: string | number | boolean, isStyle?: boolean) => void
-  onSubmit: (event: React.FormEvent<HTMLFormElement>) => void
-}
-
-export const Form: React.FunctionComponent<IFormProps> = (props) => {
-  if (props.isDynamicInput) {
-    return <DynamicForm
-      properties={props.properties}
-      symbols={props.symbols}
-      onChange={props.onChange}
-    />;
-  }
-  return <StaticForm
-    properties={props.properties}
-    onSubmit={props.onSubmit}
-  />;
-};

src/Components/Properties/StaticForm.tsx

@@ -1,159 +0,0 @@
-import { MenuAlt2Icon, MenuIcon, MenuAlt3Icon } from '@heroicons/react/outline';
-import * as React from 'react';
-import { XPositionReference } from '../../Enums/XPositionReference';
-import IContainerProperties from '../../Interfaces/IContainerProperties';
-import { transformX } from '../../utils/svg';
-import { InputGroup } from '../InputGroup/InputGroup';
-import { RadioGroupButtons } from '../RadioGroupButtons/RadioGroupButtons';
-
-interface IStaticFormProps {
-  properties: IContainerProperties
-  onSubmit: (event: React.FormEvent<HTMLFormElement>) => void
-}
-
-const getCSSInputs = (properties: IContainerProperties): JSX.Element[] => {
-  const groupInput: JSX.Element[] = [];
-  for (const key in properties.style) {
-    groupInput.push(<InputGroup
-      key={key}
-      labelText={key}
-      inputKey={key}
-      labelClassName=''
-      inputClassName=''
-      type='string'
-      defaultValue={(properties.style as any)[key]}
-    />);
-  }
-  return groupInput;
-};
-
-const StaticForm: React.FunctionComponent<IStaticFormProps> = (props) => {
-  return (<form
-    key={props.properties.id}
-    onSubmit={(event) => props.onSubmit(event)}
-  >
-    <input type='submit' className='normal-btn block mx-auto mb-4 border-2 border-blue-400 cursor-pointer' value='Submit'/>
-    <div className='grid grid-cols-2 gap-y-4'>
-      <InputGroup
-        labelText='Name'
-        inputKey='id'
-        labelClassName=''
-        inputClassName=''
-        type='string'
-        defaultValue={props.properties.id.toString()}
-        isDisabled={true}
-      />
-      <InputGroup
-        labelText='Parent name'
-        inputKey='parentId'
-        labelClassName=''
-        inputClassName=''
-        type='string'
-        defaultValue={props.properties.parentId?.toString()}
-        isDisabled={true}
-      />
-      <InputGroup
-        labelText='Displayed text'
-        inputKey='displayedText'
-        labelClassName=''
-        inputClassName=''
-        type='string'
-        defaultValue={props.properties.displayedText?.toString()}
-      />
-      <InputGroup
-        labelText='x'
-        inputKey='x'
-        labelClassName=''
-        inputClassName=''
-        type='number'
-        defaultValue={transformX(props.properties.x, props.properties.width, props.properties.XPositionReference).toString()}
-      />
-      <InputGroup
-        labelText='y'
-        inputKey='y'
-        labelClassName=''
-        inputClassName=''
-        type='number'
-        defaultValue={props.properties.y.toString()}
-      />
-      <InputGroup
-        labelText='Minimum width'
-        inputKey='minWidth'
-        labelClassName=''
-        inputClassName=''
-        type='number'
-        min={0}
-        defaultValue={props.properties.minWidth.toString()}
-      />
-      <InputGroup
-        labelText='Width'
-        inputKey='width'
-        labelClassName=''
-        inputClassName=''
-        type='number'
-        min={props.properties.minWidth}
-        defaultValue={props.properties.width.toString()}
-      />
-      <InputGroup
-        labelText='Height'
-        inputKey='height'
-        labelClassName=''
-        inputClassName=''
-        type='number'
-        min={1}
-        defaultValue={props.properties.height.toString()}
-      />
-      <InputGroup
-        labelText='Rigid'
-        inputKey='isRigidBody'
-        labelClassName=''
-        inputClassName=''
-        type='checkbox'
-        defaultChecked={props.properties.isRigidBody}
-      />
-      <InputGroup
-        labelText='Anchor'
-        inputKey='isAnchor'
-        labelClassName=''
-        inputClassName=''
-        type='checkbox'
-        defaultChecked={props.properties.isAnchor}
-      />
-      <RadioGroupButtons
-        name='XPositionReference'
-        defaultValue={props.properties.XPositionReference.toString()}
-        inputClassName='hidden'
-        labelText='Horizontal alignment'
-        inputGroups={[
-          {
-            text: (
-              <div title='Left' aria-label='left' className='radio-button-icon'>
-                <MenuAlt2Icon className='heroicon' />
-              </div>
-            ),
-            value: XPositionReference.Left.toString()
-          },
-          {
-            text: (
-              <div title='Center' aria-label='center' className='radio-button-icon'>
-                <MenuIcon className='heroicon' />
-              </div>
-            ),
-            value: XPositionReference.Center.toString()
-          },
-          {
-            text: (
-              <div title='Right' aria-label='right' className='radio-button-icon'>
-                <MenuAlt3Icon className='heroicon' />
-              </div>
-            ),
-            value: XPositionReference.Right.toString()
-          }
-        ]}
-      />
-      { getCSSInputs(props.properties) }
-    </div>
-  </form>);
-};
-
-export default StaticForm;

src/Components/SymbolProperties/Form.tsx

@@ -1,17 +0,0 @@
-import * as React from 'react';
-import { ISymbolModel } from '../../Interfaces/ISymbolModel';
-import DynamicForm from './DynamicForm';
-
-interface IFormProps {
-  symbol: ISymbolModel
-  symbols: Map<string, ISymbolModel>
-  onChange: (key: string, value: string | number | boolean, isStyle?: boolean) => void
-}
-
-export const Form: React.FunctionComponent<IFormProps> = (props) => {
-  return <DynamicForm
-    symbol={props.symbol}
-    symbols={props.symbols}
-    onChange={props.onChange}
-  />;
-};

src/Components/SymbolProperties/SymbolForm.tsx

@@ -3,12 +3,12 @@ import { ISymbolModel } from '../../Interfaces/ISymbolModel';
 import { restoreX, transformX } from '../../utils/svg';
 import { InputGroup } from '../InputGroup/InputGroup';
 
-interface IDynamicFormProps {
+interface ISymbolFormProps {
   symbol: ISymbolModel
   symbols: Map<string, ISymbolModel>
   onChange: (key: string, value: string | number | boolean) => void
 }
-const DynamicForm: React.FunctionComponent<IDynamicFormProps> = (props) => {
+const SymbolForm: React.FunctionComponent<ISymbolFormProps> = (props) => {
   return (
     <div className='grid grid-cols-2 gap-y-4'>
       <InputGroup
@@ -53,4 +53,4 @@ const DynamicForm: React.FunctionComponent<IDynamicFormProps> = (props) => {
   );
 };
 
-export default DynamicForm;
+export default SymbolForm;

src/Components/SymbolProperties/SymbolProperties.tsx

@@ -1,8 +1,6 @@
-import React, { useState } from 'react';
-import IContainerProperties from '../../Interfaces/IContainerProperties';
+import React from 'react';
 import { ISymbolModel } from '../../Interfaces/ISymbolModel';
-import { ToggleButton } from '../ToggleButton/ToggleButton';
-import { Form } from './Form';
+import SymbolForm from './SymbolForm';
 
 interface ISymbolPropertiesProps {
   symbol?: ISymbolModel
@@ -17,7 +15,7 @@ export const SymbolProperties: React.FC<ISymbolPropertiesProps> = (props: ISymbo
 
   return (
     <div className='h-3/5 p-3 bg-slate-200 overflow-y-auto'>
-      <Form
+      <SymbolForm
         symbol={props.symbol}
         symbols={props.symbols}
         onChange={props.onChange}

src/Components/UI/UI.tsx

@@ -22,7 +22,6 @@ interface IUIProps {
   SelectContainer: (containerId: string) => void
   DeleteContainer: (containerId: string) => void
   OnPropertyChange: (key: string, value: string | number | boolean, isStyle?: boolean) => void
-  OnPropertiesSubmit: (event: React.FormEvent<HTMLFormElement>) => void
   AddContainerToSelectedContainer: (type: string) => void
   AddContainer: (index: number, type: string, parentId: string) => void
   AddSymbol: (type: string) => void
@@ -90,7 +89,6 @@ export const UI: React.FunctionComponent<IUIProps> = (props: IUIProps) => {
         isOpen={isSidebarOpen}
         isHistoryOpen={isHistoryOpen}
         OnPropertyChange={props.OnPropertyChange}
-        OnPropertiesSubmit={props.OnPropertiesSubmit}
         SelectContainer={props.SelectContainer}
         DeleteContainer={props.DeleteContainer}
         AddContainer={props.AddContainer}