From 9dcfc5f2260dde6f0e75acca9c9c6e1b99e0ae5b Mon Sep 17 00:00:00 2001 From: Eric Nguyen Date: Mon, 8 Aug 2022 14:55:40 +0000 Subject: [PATCH] Merged PR 13: Fix azure-pipeline node kill We use killall to stop node from running but az pipe catch SIGTERM. Let's rather use SIGINT --- .drone.yml | 4 +++- azure-pipelines.yml | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.drone.yml b/.drone.yml index 0a843af..8d7a147 100644 --- a/.drone.yml +++ b/.drone.yml @@ -9,6 +9,7 @@ steps: - node ./test-server/node-http.js & - npm install - npm run test:nowatch + - kill -2 %1 2>/dev/null --- kind: pipeline @@ -20,4 +21,5 @@ steps: commands: - node ./test-server/node-http.js & - npm install - - npm run test:nowatch \ No newline at end of file + - npm run test:nowatch + - kill -2 %1 2>/dev/null \ No newline at end of file diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 9a751fc..28f4504 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -23,7 +23,7 @@ steps: jobs npm ci npm run test:nowatch - killall node + kill -2 %1 2>/dev/null displayName: 'Test on Node.js 16.x LTS' - task: NodeTool@0 @@ -37,5 +37,5 @@ steps: jobs npm ci npm run test:nowatch - killall node + kill -2 %1 2>/dev/null displayName: 'Test on Node.js 18.x Latest' \ No newline at end of file