Siklos/svg-layout-designer-react
1
1
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix regression + fix tests
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details

Browse source
This commit is contained in:
Siklos 2022-08-11 14:36:25 +02:00
parent 3d710f6f7e
commit d07353d02e
3 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/Components/ElementsSidebar/ElementsSidebar.test.tsx
View file

@ -72,12 +72,12 @@ describe.concurrent('Elements sidebar', () => {
expect(screen.queryByText('y')).toBeDefined(); expect(screen.queryByText('y')).toBeDefined();
expect(screen.queryByText('width')).toBeDefined(); expect(screen.queryByText('width')).toBeDefined();
expect(screen.queryByText('height')).toBeDefined(); expect(screen.queryByText('height')).toBeDefined();
const propertyId = container.querySelector('#property-id'); const propertyId = container.querySelector('#id');
const propertyParentId = container.querySelector('#property-parentId'); const propertyParentId = container.querySelector('#parentId');
const propertyX = container.querySelector('#property-x'); const propertyX = container.querySelector('#x');
const propertyY = container.querySelector('#property-y'); const propertyY = container.querySelector('#y');
const propertyWidth = container.querySelector('#property-width'); const propertyWidth = container.querySelector('#width');
const propertyHeight = container.querySelector('#property-height'); const propertyHeight = container.querySelector('#height');
expect((propertyId as HTMLInputElement).value).toBe(MainContainer.properties.id.toString()); expect((propertyId as HTMLInputElement).value).toBe(MainContainer.properties.id.toString());
expect(propertyParentId).toBeDefined(); expect(propertyParentId).toBeDefined();
expect((propertyParentId as HTMLInputElement).value).toBe(''); expect((propertyParentId as HTMLInputElement).value).toBe('');
@ -216,8 +216,8 @@ describe.concurrent('Elements sidebar', () => {
expect(screen.getByText(/main/i)); expect(screen.getByText(/main/i));
const child1 = screen.getByText(/child-1/i); const child1 = screen.getByText(/child-1/i);
expect(child1); expect(child1);
const propertyId = container.querySelector('#property-id'); const propertyId = container.querySelector('#id');
const propertyParentId = container.querySelector('#property-parentId'); const propertyParentId = container.querySelector('#parentId');
expect((propertyId as HTMLInputElement).value).toBe(MainContainer.properties.id.toString()); expect((propertyId as HTMLInputElement).value).toBe(MainContainer.properties.id.toString());
expect((propertyParentId as HTMLInputElement).value).toBe(''); expect((propertyParentId as HTMLInputElement).value).toBe('');

18
src/Components/Properties/Properties.test.tsx
View file

@ -17,7 +17,7 @@ describe.concurrent('Properties', () => {
expect(screen.queryByText('y')).toBeNull(); expect(screen.queryByText('y')).toBeNull();
}); });
it('Some properties', () => { it('Some properties, change values with dynamic input', () => {
const prop = { const prop = {
id: 'stuff', id: 'stuff',
parentId: 'parentId', parentId: 'parentId',
@ -41,10 +41,10 @@ describe.concurrent('Properties', () => {
expect(screen.queryByText('x')).toBeDefined(); expect(screen.queryByText('x')).toBeDefined();
expect(screen.queryByText('y')).toBeDefined(); expect(screen.queryByText('y')).toBeDefined();
let propertyId = container.querySelector('#property-id'); let propertyId = container.querySelector('#id');
let propertyParentId = container.querySelector('#property-parentId'); let propertyParentId = container.querySelector('#parentId');
let propertyX = container.querySelector('#property-x'); let propertyX = container.querySelector('#x');
let propertyY = container.querySelector('#property-y'); let propertyY = container.querySelector('#y');
expect(propertyId).toBeDefined(); expect(propertyId).toBeDefined();
expect((propertyId as HTMLInputElement).value).toBe('stuff'); expect((propertyId as HTMLInputElement).value).toBe('stuff');
expect(propertyParentId).toBeDefined(); expect(propertyParentId).toBeDefined();
@ -70,10 +70,10 @@ describe.concurrent('Properties', () => {
onSubmit={() => {}} onSubmit={() => {}}
/>); />);
propertyId = container.querySelector('#property-id'); propertyId = container.querySelector('#id');
propertyParentId = container.querySelector('#property-parentId'); propertyParentId = container.querySelector('#parentId');
propertyX = container.querySelector('#property-x'); propertyX = container.querySelector('#x');
propertyY = container.querySelector('#property-y'); propertyY = container.querySelector('#y');
expect(propertyId).toBeDefined(); expect(propertyId).toBeDefined();
expect((propertyId as HTMLInputElement).value).toBe('stuffed'); expect((propertyId as HTMLInputElement).value).toBe('stuffed');
expect(propertyParentId).toBeDefined(); expect(propertyParentId).toBeDefined();

2
src/Components/Properties/Properties.tsx
View file

@ -10,7 +10,7 @@ interface IPropertiesProps {
} }
export const Properties: React.FC<IPropertiesProps> = (props: IPropertiesProps) => { export const Properties: React.FC<IPropertiesProps> = (props: IPropertiesProps) => {
const [isDynamicInput, setIsDynamicInput] = useState<boolean>(false); const [isDynamicInput, setIsDynamicInput] = useState<boolean>(true);
if (props.properties === undefined) { if (props.properties === undefined) {
return <div></div>; return <div></div>;