Siklos/svg-layout-designer-react
1
1
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix ChildrenDimension not using x
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details

Browse source
This commit is contained in:
Eric NGUYEN 2022-08-16 14:54:53 +02:00
parent 1bd0d1c796
commit dc582d3365
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/Components/SVG/Elements/Container.tsx
View file

@ -50,7 +50,7 @@ export const Container: React.FC<IContainerProps> = (props: IContainerProps) =>
const text = (props.model.properties.width ?? 0).toString(); const text = (props.model.properties.width ?? 0).toString();
let dimensionChildren: JSX.Element | null = null; let dimensionChildren: JSX.Element | null = null;
if (props.model.children.length > 0) { if (props.model.children.length > 1) {
const { const {
childrenId, childrenId,
xChildrenStart, xChildrenStart,
@ -108,14 +108,16 @@ function GetChildrenDimensionProps(props: IContainerProps, dimensionMargin: numb
const lastChild = props.model.children[props.model.children.length - 1]; const lastChild = props.model.children[props.model.children.length - 1];
let xChildrenStart = lastChild.properties.x; let xChildrenStart = lastChild.properties.x;
let xChildrenEnd = lastChild.properties.x + lastChild.properties.width; let xChildrenEnd = lastChild.properties.x;
// Find the min and max
for (let i = props.model.children.length - 2; i >= 0; i--) { for (let i = props.model.children.length - 2; i >= 0; i--) {
const child = props.model.children[i]; const child = props.model.children[i];
const left = child.properties.x; const left = child.properties.x;
if (left < xChildrenStart) { if (left < xChildrenStart) {
xChildrenStart = left; xChildrenStart = left;
} }
const right = child.properties.x + child.properties.width; const right = child.properties.x;
if (right > xChildrenEnd) { if (right > xChildrenEnd) {
xChildrenEnd = right; xChildrenEnd = right;
} }