From f5ec81d22bccaa160d121038477135c50aed8561 Mon Sep 17 00:00:00 2001
From: Eric NGUYEN <enguyen@techform.fr>
Date: Thu, 13 Oct 2022 18:14:54 +0200
Subject: [PATCH] Fix React Error on setState while rendering a different
 component

---
 src/Components/App/Actions/MenuActions.ts | 32 +++++++++++++----------
 src/Components/App/App.tsx                | 10 +++++--
 2 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/src/Components/App/Actions/MenuActions.ts b/src/Components/App/Actions/MenuActions.ts
index abf2cbc..b81561f 100644
--- a/src/Components/App/Actions/MenuActions.ts
+++ b/src/Components/App/Actions/MenuActions.ts
@@ -1,4 +1,4 @@
-import { Dispatch, SetStateAction } from 'react';
+import { Dispatch, SetStateAction, useEffect } from 'react';
 import { IConfiguration } from '../../../Interfaces/IConfiguration';
 import { FetchConfiguration } from '../../API/api';
 import { IEditorState } from '../../../Interfaces/IEditorState';
@@ -7,18 +7,10 @@ import { DISABLE_API, GetDefaultEditorState } from '../../../utils/default';
 
 export function NewEditor(
   editorState: IEditorState,
-  setEditorState: Dispatch<SetStateAction<IEditorState>>,
-  setLoaded: Dispatch<SetStateAction<boolean>>
+  setEditorState: (newState: IEditorState) => void,
+  enableLoaded: () => void
 ): void {
-  if (DISABLE_API) {
-    setLoaded(true);
-    return;
-  }
-
-  if (editorState.configuration !== undefined) {
-    setLoaded(true);
-    return;
-  }
+  UseLoadOnBoot(enableLoaded, editorState);
 
   // Fetch the configuration from the API
   FetchConfiguration()
@@ -27,13 +19,25 @@ export function NewEditor(
       const editorState: IEditorState = GetDefaultEditorState(configuration);
 
       setEditorState(editorState);
-      setLoaded(true);
+      enableLoaded();
     }, (error) => {
       console.debug('[NewEditor] Could not fetch resource from API. Using default.', error);
-      setLoaded(true);
+      enableLoaded();
     });
 }
 
+function UseLoadOnBoot(enableLoaded: () => void, editorState: IEditorState): void {
+  useEffect(() => {
+    if (DISABLE_API) {
+      enableLoaded();
+      return;
+    }
+    if (editorState.configuration !== undefined) {
+      enableLoaded();
+    }
+  }, []);
+}
+
 export function LoadEditor(
   files: FileList | null,
   setEditorState: Dispatch<SetStateAction<IEditorState>>,
diff --git a/src/Components/App/App.tsx b/src/Components/App/App.tsx
index 639d1de..ccf556d 100644
--- a/src/Components/App/App.tsx
+++ b/src/Components/App/App.tsx
@@ -1,4 +1,4 @@
-import React, { Dispatch, SetStateAction, useEffect, useRef, useState } from 'react';
+import React, { Dispatch, SetStateAction, useCallback, useEffect, useRef, useState } from 'react';
 import { events as EVENTS } from '../../Events/AppEvents';
 import { MainMenu } from '../MainMenu/MainMenu';
 import { ContainerModel, IContainerModel } from '../../Interfaces/IContainerModel';
@@ -107,6 +107,10 @@ export function App(props: IAppProps): JSX.Element {
 
   UseHTTPGETStatePreloading(isLoaded, setEditorState, setLoaded);
 
+  const enableLoaded = useCallback(() => {
+    setLoaded(true);
+  }, []);
+
   if (isLoaded) {
     return (
       <div
@@ -130,7 +134,9 @@ export function App(props: IAppProps): JSX.Element {
     >
       <MainMenu
         newEditor={() => NewEditor(
-          editorState, setEditorState, setLoaded
+          editorState,
+          (newEditor) => setEditorState(newEditor),
+          enableLoaded
         )}
         loadEditor={(files: FileList | null) => LoadEditor(
           files,