Fixed leaks in some fragments

This commit is contained in:
Prathamesh More 2022-05-28 00:09:49 +05:30
parent be6b48f8e0
commit 14f31eae37
5 changed files with 18 additions and 1 deletions

View file

@ -174,7 +174,7 @@ class SkuDetailsAdapter(
override fun onBindViewHolder(viewHolder: ViewHolder, i: Int) { override fun onBindViewHolder(viewHolder: ViewHolder, i: Int) {
val skuDetails = skuDetailsList[i] val skuDetails = skuDetailsList[i]
with(viewHolder.binding) { with(viewHolder.binding) {
itemTitle.text = skuDetails.title.replace("Retro Music Player MP3 Player", "") itemTitle.text = skuDetails.title.replace("(Retro Music Player MP3 Player)", "")
.trim { it <= ' ' } .trim { it <= ' ' }
itemText.text = skuDetails.description itemText.text = skuDetails.description
itemText.isVisible = false itemText.isVisible = false

View file

@ -154,4 +154,9 @@ class BackupFragment : Fragment(R.layout.fragment_backup), BackupAdapter.BackupC
} }
return false return false
} }
override fun onDestroyView() {
super.onDestroyView()
_binding = null
}
} }

View file

@ -76,6 +76,7 @@ GenresFragment : AbsRecyclerViewFragment<GenreAdapter, LinearLayoutManager>(),
} }
override val titleRes: Int override val titleRes: Int
get() = R.string.genres get() = R.string.genres

View file

@ -425,11 +425,17 @@ class LyricsFragment : AbsMainActivityFragment(R.layout.fragment_lyrics) {
super.onPause() super.onPause()
updateHelper.stop() updateHelper.stop()
} }
override fun onDestroyView() {
super.onDestroyView()
_binding = null
}
} }
override fun onDestroyView() { override fun onDestroyView() {
super.onDestroyView() super.onDestroyView()
if (MusicPlayerRemote.playingQueue.isNotEmpty()) if (MusicPlayerRemote.playingQueue.isNotEmpty())
(requireActivity() as MainActivity).expandPanel() (requireActivity() as MainActivity).expandPanel()
_binding = null
} }
} }

View file

@ -101,6 +101,11 @@ class SettingsFragment : AbsMusicServiceFragment(R.layout.fragment_settings), Co
bottom = if (MusicPlayerRemote.playingQueue.isEmpty()) 0 else dip(R.dimen.mini_player_height)) bottom = if (MusicPlayerRemote.playingQueue.isEmpty()) 0 else dip(R.dimen.mini_player_height))
} }
override fun onDestroyView() {
super.onDestroyView()
_binding = null
}
companion object { companion object {
val TAG: String = SettingsFragment::class.java.simpleName val TAG: String = SettingsFragment::class.java.simpleName
} }