Refined seletable

app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AbsTagEditorActivity.kt

@@ -19,6 +19,7 @@ import code.name.monkey.appthemehelper.util.ColorUtil
 import code.name.monkey.appthemehelper.util.MaterialValueHelper
 import code.name.monkey.appthemehelper.util.TintHelper
 import code.name.monkey.retromusic.R
+import code.name.monkey.retromusic.R.drawable
 import code.name.monkey.retromusic.activities.base.AbsBaseActivity
 import code.name.monkey.retromusic.activities.saf.SAFGuideActivity
 import code.name.monkey.retromusic.util.PreferenceUtil
@@ -321,7 +322,7 @@ abstract class AbsTagEditorActivity : AbsBaseActivity() {
 
     protected fun setImageBitmap(bitmap: Bitmap?, bgColor: Int) {
         if (bitmap == null) {
-            editorImage.setImageResource(code.name.monkey.retromusic.R.drawable.default_album_art)
+            editorImage.setImageResource(drawable.default_album_art)
         } else {
             editorImage.setImageBitmap(bitmap)
         }
@@ -414,4 +415,5 @@ abstract class AbsTagEditorActivity : AbsBaseActivity() {
         private val TAG = AbsTagEditorActivity::class.java.simpleName
         private const val REQUEST_CODE_SELECT_IMAGE = 1000
     }
+
 }

app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AlbumTagEditorActivity.kt

@@ -9,7 +9,6 @@ import android.graphics.drawable.Drawable
 import android.net.Uri
 import android.os.Bundle
 import android.text.Editable
-import android.text.TextUtils
 import android.text.TextWatcher
 import android.transition.Slide
 import android.widget.Toast
@@ -22,9 +21,7 @@ import code.name.monkey.retromusic.glide.palette.BitmapPaletteTranscoder
 import code.name.monkey.retromusic.glide.palette.BitmapPaletteWrapper
 import code.name.monkey.retromusic.loaders.AlbumLoader
 import code.name.monkey.retromusic.rest.LastFMRestClient
-import code.name.monkey.retromusic.rest.model.LastFmAlbum
 import code.name.monkey.retromusic.util.ImageUtil
-import code.name.monkey.retromusic.util.LastFMUtil
 import code.name.monkey.retromusic.util.RetroColorUtil.generatePalette
 import code.name.monkey.retromusic.util.RetroColorUtil.getColor
 import com.bumptech.glide.Glide
@@ -151,62 +148,6 @@ class AlbumTagEditorActivity : AbsTagEditorActivity(), TextWatcher {
         disposable.clear()
     }
 
-    private fun extractDetails(lastFmAlbum: LastFmAlbum) {
-        if (lastFmAlbum.album != null) {
-
-            val url = LastFMUtil.getLargestAlbumImageUrl(lastFmAlbum.album.image)
-
-            if (!TextUtils.isEmpty(url) && url.trim { it <= ' ' }.isNotEmpty()) {
-                Glide.with(this@AlbumTagEditorActivity).load(url).asBitmap()
-                    .transcode(BitmapPaletteTranscoder(this), BitmapPaletteWrapper::class.java)
-                    .diskCacheStrategy(DiskCacheStrategy.SOURCE).error(R.drawable.default_album_art)
-                    .into(object : SimpleTarget<BitmapPaletteWrapper>() {
-                        override fun onLoadFailed(
-                            e: java.lang.Exception?,
-                            errorDrawable: Drawable?
-                        ) {
-                            super.onLoadFailed(e, errorDrawable)
-                            Toast.makeText(
-                                this@AlbumTagEditorActivity,
-                                e.toString(),
-                                Toast.LENGTH_LONG
-                            ).show()
-                        }
-
-                        override fun onResourceReady(
-                            resource: BitmapPaletteWrapper?,
-                            glideAnimation: GlideAnimation<in BitmapPaletteWrapper>?
-                        ) {
-                            albumArtBitmap = resource?.bitmap?.let {
-                                ImageUtil.resizeBitmap(
-                                    it,
-                                    2048
-                                )
-                            }
-                            setImageBitmap(
-                                albumArtBitmap,
-                                getColor(
-                                    resource?.palette,
-                                    ATHUtil.resolveColor(
-                                        this@AlbumTagEditorActivity,
-                                        R.attr.defaultFooterColor
-                                    )
-                                )
-                            )
-                            deleteAlbumArt = false
-                            dataChanged()
-                            setResult(RESULT_OK)
-                        }
-                    })
-                return
-            }
-            if (lastFmAlbum.album.tags.tag.size > 0) {
-                genreTitle.setText(lastFmAlbum.album.tags.tag[0].name)
-            }
-        }
-        toastLoadingFailed()
-    }
-
     private fun toastLoadingFailed() {
         Toast.makeText(
             this@AlbumTagEditorActivity,
@@ -237,8 +178,8 @@ class AlbumTagEditorActivity : AbsTagEditorActivity(), TextWatcher {
         fieldKeyValueMap[FieldKey.GENRE] = genreTitle.text.toString()
         fieldKeyValueMap[FieldKey.YEAR] = yearTitle.text.toString()
 
-        writeValuesToFiles(
-            fieldKeyValueMap, if (deleteAlbumArt) ArtworkInfo(id, null)
+        writeValuesToFiles(fieldKeyValueMap,
+            if (deleteAlbumArt) ArtworkInfo(id, null)
             else if (albumArtBitmap == null) null else ArtworkInfo(id, albumArtBitmap!!)
         )
     }

app/src/main/java/code/name/monkey/retromusic/fragments/settings/AbsSettingsFragment.kt

@@ -37,7 +37,6 @@ import code.name.monkey.retromusic.preferences.MaterialListPreferenceDialog
 import code.name.monkey.retromusic.preferences.NowPlayingScreenPreference
 import code.name.monkey.retromusic.preferences.NowPlayingScreenPreferenceDialog
 import code.name.monkey.retromusic.util.NavigationUtil
-import me.everything.android.ui.overscroll.OverScrollDecoratorHelper
 
 /**
  * @author Hemanth S (h4h13).
@@ -80,7 +79,6 @@ abstract class AbsSettingsFragment : ATEPreferenceFragmentCompat() {
         listView.setPadding(0, 0, 0, 0)
         listView.setPaddingRelative(0, 0, 0, 0)
         invalidateSettings()
-        OverScrollDecoratorHelper.setUpOverScroll(listView, OverScrollDecoratorHelper.ORIENTATION_VERTICAL)
     }
 
     override fun onCreatePreferenceDialog(preference: Preference): DialogFragment? {

app/src/main/java/code/name/monkey/retromusic/misc/UpdateToastMediaScannerCompletionListener.java

@@ -19,21 +19,26 @@ import android.app.Activity;
 import android.media.MediaScannerConnection;
 import android.net.Uri;
 import android.widget.Toast;
-
-import java.lang.ref.WeakReference;
-
 import code.name.monkey.retromusic.R;
+import java.lang.ref.WeakReference;
 
 /**
  * @author Karim Abou Zeid (kabouzeid)
  */
 public class UpdateToastMediaScannerCompletionListener implements MediaScannerConnection.OnScanCompletedListener {
-    private final String[] toBeScanned;
-    private final String scannedFiles;
-    private final String couldNotScanFiles;
+
     private final WeakReference<Activity> activityWeakReference;
-    private int scanned = 0;
+
+    private final String couldNotScanFiles;
+
     private int failed = 0;
+
+    private int scanned = 0;
+
+    private final String scannedFiles;
+
+    private final String[] toBeScanned;
+
     private Toast toast;
 
     @SuppressLint("ShowToast")
@@ -55,7 +60,8 @@ public class UpdateToastMediaScannerCompletionListener implements MediaScannerCo
                 } else {
                     scanned++;
                 }
-                String text = " " + String.format(scannedFiles, scanned, toBeScanned.length) + (failed > 0 ? " " + String.format(couldNotScanFiles, failed) : "");
+                String text = " " + String.format(scannedFiles, scanned, toBeScanned.length) + (failed > 0 ? " "
+                        + String.format(couldNotScanFiles, failed) : "");
                 toast.setText(text);
                 toast.show();
             });