Siklos/svg-layout-designer-react
1
1
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Final fix for XPositionReference : We are now lying to the user in the form. The transformation is applied to the value that is shown but the transformation is restored for the computing afterward #33

Merged
Siklos merged 4 commits from dev.fixtransform into dev 2022-08-16 10:56:58 -04:00
Conversation 0 Commits 4 Files changed 7 +108 -67
Siklos commented 2022-08-16 10:49:15 -04:00
Owner
Copy link

Final fix for XPositionReference :

  • We are now lying to the user in the form. The transformation is applied to the value that is shown but the transformation is restored for the computing afterward
  • Fix regression on delete container
Final fix for XPositionReference : - We are now lying to the user in the form. The transformation is applied to the value that is shown but the transformation is restored for the computing afterward - Fix regression on delete container
Siklos added 3 commits 2022-08-16 10:49:16 -04:00
History: Fix regression with delete
Some checks failed
continuous-integration/drone/push Build is failing
Details
0fcc2244bb
Refactor PropertiesOperations for more readability
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
e3190dfe0a
Siklos added 1 commit 2022-08-16 10:51:52 -04:00
Fix test: when using dynamic input, the value is converted correctly as number before being send to the change event
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
a36d5d79d4
Siklos merged commit a36d5d79d4 into dev 2022-08-16 10:56:58 -04:00
Siklos deleted branch dev.fixtransform 2022-08-16 10:56:58 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Siklos/svg-layout-designer-react#33
No description provided.
Delete branch "dev.fixtransform"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?